Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double clicking a change ipynb in the working tree/changes view has side-effects #5279

Closed
tonybaloney opened this issue Mar 24, 2021 · 1 comment
Labels
bug Issue identified by VS Code Team member as probable bug

Comments

@tonybaloney
Copy link
Contributor

Environment data

  • VS Code version:
  • Jupyter Extension version (available under the Extensions sidebar): v2021.3.684299474
  • Python Extension version (available under the Extensions sidebar): v2021.4.681399556-dev
  • OS (Windows | Mac | Linux distro) and version: macOS 11.3
  • Python and/or Anaconda version: Python 3.9.1
  • Type of virtual environment used (N/A | venv | virtualenv | conda | ...): venv
  • Jupyter server running: Local

Expected behaviour

  1. Clicking and Double clicking on a changed notebook would have the same effect as any other file.
  2. A side-by-side comparison of changes is shown

Actual behaviour

Double-Clicking on a changed notebook from the source control pane opens it twice

Steps to reproduce:

  1. Edit a Jupyter notebook in a git repository
  2. Save changes
  3. Open the Source Control tab in VS Code
  4. Single Click on the .ipynb files in the Changes section on the Source Control pane
    **Issue 1: It opens the notebook, not a comparison of changes **
  5. Close the tab with the notebook
  6. Double click on the .ipynb files in the Changes section on the Source Control pane
    Issue 2: It opens the notebook twice, once as the live notebook and the second as the notebook with the tab (Working changes)
@tonybaloney tonybaloney added the bug Issue identified by VS Code Team member as probable bug label Mar 24, 2021
@DonJayamanne
Copy link
Contributor

Duplicate of #633

@DonJayamanne DonJayamanne marked this as a duplicate of #633 Mar 25, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Development

No branches or pull requests

2 participants