Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Execution of Notebooks are very slow compared to Classic Jupyter #5662

Closed
DonJayamanne opened this issue Apr 27, 2021 · 3 comments
Closed

Execution of Notebooks are very slow compared to Classic Jupyter #5662

DonJayamanne opened this issue Apr 27, 2021 · 3 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@DonJayamanne
Copy link
Contributor

DonJayamanne commented Apr 27, 2021

Run 200 cells in classic Jupyter = 0.5s
Run 200 cells in custom Editor = 9s
Run 200 cells in Native Editor = 35s

Last year I recall making some changes to ensure the perf was faster

Suggestions:

  • Synchronize messages only when we have widgets (I did this last year, either the code has been accidentally removed or still there & not workign, or other)
  • Don't wait for VS Code to update the output
@DonJayamanne DonJayamanne added the bug Issue identified by VS Code Team member as probable bug label Apr 27, 2021
@rchiodo rchiodo added this to the July 2021 Release milestone Apr 29, 2021
@greazer greazer modified the milestones: July 2021, August 2021 Jul 30, 2021
@DonJayamanne DonJayamanne self-assigned this Aug 2, 2021
@greazer greazer modified the milestones: August 2021, old August 2021 Aug 9, 2021
@DonJayamanne
Copy link
Contributor Author

We're back at 9-10s in Native notebooks, back to what it was with Custom Editor Notebooks.

Not sure we'll be able to get to 0.5s, as we run each cell sequentially instead of sending all cells to Jupyter Kernel (i.e. we run a cell, check if it fails, then proceed to the next cell).
Considering this only decreases perf when running a large number of cells, I think this is acceptable (200 cells in 10s is accpetable with this architecture),

@DonJayamanne
Copy link
Contributor Author

DonJayamanne commented Aug 23, 2021

Duplicate of #6941

@DonJayamanne DonJayamanne marked this as a duplicate of #6941 Aug 23, 2021
@DonJayamanne DonJayamanne added the verification-needed Verification of issue is requested label Aug 25, 2021
@DavidKutu
Copy link

the new time is around 12 seconds

@DavidKutu DavidKutu added the verified Verification succeeded label Aug 25, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

5 participants