Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to ESLint #62

Closed
DonJayamanne opened this issue Sep 16, 2020 · 4 comments · Fixed by #4397
Closed

Migrate to ESLint #62

DonJayamanne opened this issue Sep 16, 2020 · 4 comments · Fixed by #4397
Assignees

Comments

@DonJayamanne
Copy link
Contributor

We should start using ESLint for all of the new code & just deprecate TS Lint.
Here's my proposal:

  • Run ES Lint for all new code (the code is already in place) - core extension have already done this
    • ES Lint will not run for old code
  • Run TS Lint for old code
  • When an old file is modified, then we run ES Lint on that old modified file
    • This way, anyone making changes to old files will be forced to upgrade everything in that file to eslint
    • Majority of the time it is just ignoring a lot of any usages.

Note:

  • This is identical to the approach we took for upgrading the entire code to strict typescript. We started this at least 6months before we decided to update the remainder of the code base.
  • Most of the code required is still intact,
  • TS Lint has been deprecated, and we knew about this early last year.
  • I.e. time to act now, but probably after most of the code has been stabilized
@rchiodo
Copy link
Contributor

rchiodo commented Sep 16, 2020

How do we distinguish 'old' code from 'new' code in the linter?

@rchiodo
Copy link
Contributor

rchiodo commented Sep 16, 2020

Oh and why is ES Lint superior? TS Lint seems pretty good so far.

@rchiodo
Copy link
Contributor

rchiodo commented Sep 16, 2020

This explains the why:
microsoft/TypeScript#29288 (comment)

@DonJayamanne
Copy link
Contributor Author

How do we distinguish 'old' code from 'new' code in the linter?

This file contains list of old files https://github.com/microsoft/vscode-jupyter/blob/main/.eslintignore

@DonJayamanne DonJayamanne self-assigned this Sep 17, 2020
@DonJayamanne DonJayamanne assigned rchiodo and unassigned DonJayamanne Jan 15, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants