Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating interactive window scans for all kernel specs #6672

Closed
rebornix opened this issue Jul 15, 2021 · 4 comments
Closed

Creating interactive window scans for all kernel specs #6672

rebornix opened this issue Jul 15, 2021 · 4 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug interactive-window Impacts interactive window perf Performance issues

Comments

@rebornix
Copy link
Member

Issue Type: Bug

  • Open a python file
  • Run code from code lens
  • Check the output log, it scans for all kernel specs

Extension version: 2021.8.1025925145
VS Code version: Code - Insiders 1.59.0-insider (9520f0a515e7e24802c92f885a0efb242fca3831, 2021-07-14T07:15:41.024Z)
OS version: Windows_NT x64 10.0.19041
Restricted Mode: No

@joyceerhl
Copy link
Contributor

@rebornix This is expected behavior, no? Otherwise the kernel picker will not be populated with kernels.

@DonJayamanne DonJayamanne removed their assignment Jul 15, 2021
@rebornix
Copy link
Member Author

It's an expected behavior, but the scanning starts too early and slows down the requested code execution. It can affect the speed of daemon and the kernel creation (by using more cpu cycles) and also main thread of extension host. Curious about how much we can gain for postponing everything not needed for the first cell execution (including the second kernel process for faster restart purpose). Any ideas?

@DonJayamanne DonJayamanne added the perf Performance issues label Jul 15, 2021
@DonJayamanne
Copy link
Contributor

Any ideas?

Previously the second kernel process used to start immidiately, I moved the code to when we we run some code against the first kernel process. This resulted in a big improvement (hence the reason for changing that). I'm certain that removing it entirely will have benefits. Lets discuss offline today.

@greazer greazer added the interactive-window Impacts interactive window label Aug 4, 2021
@greazer greazer added the bug Issue identified by VS Code Team member as probable bug label Oct 9, 2021
@amunger amunger removed their assignment Aug 16, 2022
@amunger
Copy link
Contributor

amunger commented Mar 2, 2023

improvements have been made, wont fix for now

@amunger amunger closed this as not planned Won't fix, can't repro, duplicate, stale Mar 2, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug interactive-window Impacts interactive window perf Performance issues
Projects
None yet
Development

No branches or pull requests

5 participants