Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wall of notifications #6886

Closed
Tracked by #10749
kieferrm opened this issue Jul 28, 2021 · 3 comments
Closed
Tracked by #10749

Wall of notifications #6886

kieferrm opened this issue Jul 28, 2021 · 3 comments
Labels
bug Issue identified by VS Code Team member as probable bug notebook-getting-started

Comments

@kieferrm
Copy link
Member

kieferrm commented Jul 28, 2021

Testing #6821

  1. dev container without python
  2. create untitled notebook with a python code cell
  3. install python extension

image

If Python is not installed, none of them really make sense.

@kieferrm kieferrm added the bug Issue identified by VS Code Team member as probable bug label Jul 29, 2021
@kieferrm
Copy link
Member Author

With the welcome editor it become even more celebratory:

image

@IanMatthewHuff
Copy link
Member

This was more of a meta issue that has been resolved by recent getting started v-team work. The welcome page has been cut out in both the scenario where you install Jupyter + Python from the marketplace (@lramos15 's work) as well as when you install Python via the kernel picker command (via me and Jupyter extension). The warning from Jupyter that you might need to restart I've also removed unless you have an active kernel running at the time of the install.

The other notifications are from the Python team. The "Python is not installed" warning I believe is removed from this scenario (@karrtikr for info) I believe that the "Do you want to use insiders" is still there though. I'm considering closing this from the Jupyter end, but if we still have the two Python messages I could transfer it as well. @karrtikr opinion on that?

@karrtikr
Copy link
Contributor

Python extension no longer has any of these prompts, so feel free to close.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug notebook-getting-started
Projects
None yet
Development

No branches or pull requests

5 participants