Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable Web View Tests we have been skipping #7028

Closed
10 of 41 tasks
DonJayamanne opened this issue Aug 9, 2021 · 2 comments
Closed
10 of 41 tasks

Re-enable Web View Tests we have been skipping #7028

DonJayamanne opened this issue Aug 9, 2021 · 2 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug debt Code quality issues

Comments

@DonJayamanne
Copy link
Contributor

DonJayamanne commented Aug 9, 2021

  • Notebook Tests
    • Remote Self Certificate
    • Remote No auth (Connect to a server that doesn't have a token or password, customers use this and we regressed it once)
    • Remote Deny insecure (For a connection to a remote machine that is not secure deny the connection and we should not connect)
    • Remote Password
    • Export/Import
    • Non default config fails (should not be able to connect to notebook server with bad config)
    • Custom command line (@DonJayamanne)
    • Invalid kernelspec works (@DonJayamanne) - no longer applicable after refactoring
    • Kernelspec generates an env section for a conda env: Interactive Window for new conda env creates kernel using different conda os.sys.path #7186 (@DonJayamanne)
    • Server cache working (@DonJayamanne)
    • Execution logging (we only need tests for pre-execute, post execute should be removed & we should use native VS Code API)
    • Notebook launch failure
    • Startup commands (@DonJayamanne)
    • Current directory (@DonJayamanne)
  • Native Editor functional tests @rchiodo
    • Export with no python
    • Invalid session still runs
    • Invalid kernel still runs
    • Invalid kernel can be switched
    • Select Jupyter Server
    • Server already loaded
    • Server load skipped
    • Convert to python
    • Toggle visibility of output (tests for custom commands), e.g.
    • Stop on Error Off (with setting off, I think this is required for Interactive Window)
  • Jupyter Provider Registration
  • Interactive Window
    • Export
    • Restart with session failure (I don't think we should do this, when using Native Notebook controller code, this will be unnecessary. Else we'll have to write test for everything we have in Native notebooks, & that seems wrong)
    • Copy back to source
  • 🏃 Intellisense Functional tests @rchiodo
    • 🏃 Filtered Jupyter autocomplete, verify magic commands appear
    • 🏃 Filtered Jupyter autocomplete, verify magic commands are filtered
    • 🏃 Hover on interactive
  • Raw kernel (not required, as we have sufficient native notebook tests that cover this)
  • Variable Explorer tests
  • Plot Viewer tests
  • IPyWidget tests
  • Run-By-Line tests
@DonJayamanne DonJayamanne added the bug Issue identified by VS Code Team member as probable bug label Aug 9, 2021
@rchiodo rchiodo added debt Code quality issues and removed needs-triage labels Aug 12, 2021
@greazer greazer changed the title Web View Tests skipped Re-enable Web View Tests we have been skipping Aug 25, 2021
@kieferrm
Copy link
Member

Needs to be split and resulting issue be assigned to owners.

@amunger
Copy link
Contributor

amunger commented Dec 5, 2022

from a quick spot check, I don't see these tests anymore. closing as stale

@amunger amunger closed this as not planned Won't fix, can't repro, duplicate, stale Dec 5, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug debt Code quality issues
Projects
None yet
Development

No branches or pull requests

5 participants