Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the support of Semantic Token Colorization in JupyterNotebook like in the python file #7225

Closed
gonghenghai opened this issue Aug 23, 2021 · 2 comments
Closed

Add the support of Semantic Token Colorization in JupyterNotebook like in the python file #7225

gonghenghai opened this issue Aug 23, 2021 · 2 comments
Assignees
@joyceerhl
Labels
bug Issue identified by VS Code Team member as probable bug notebook-intellisense Intellisense & other language features in notebook cells for any language

Comments

@gonghenghai
Copy link

gonghenghai commented Aug 23, 2021 •
edited
Loading

Jupyter notebook lacks the ability of Semantic Token Colorization:

The theme of Dark+:

enter image description here

enter image description here

The theme of SynthWave '84:

enter image description here

enter image description here
@joyceerhl
Copy link
Contributor

Thanks for the suggestion. Not sure if we need to do extra work in the notebook LSP middleware module to support this https://microsoft.github.io/language-server-protocol/specifications/specification-current/#textDocument_semanticTokens

@greazer greazer added notebook-intellisense Intellisense & other language features in notebook cells for any language bug Issue identified by VS Code Team member as probable bug and removed enhancement labels Aug 23, 2021
@greazer
Copy link
Member

greazer commented Aug 23, 2021

Dupe of #6799. Closing.

@greazer greazer closed this as completed Aug 23, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joyceerhl joyceerhl

Labels
bug Issue identified by VS Code Team member as probable bug notebook-intellisense Intellisense & other language features in notebook cells for any language
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@greazer @gonghenghai @joyceerhl