Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Live Share for native interactive window #7460

Open
joyceerhl opened this issue Sep 8, 2021 · 11 comments
Open

Implement Live Share for native interactive window #7460

joyceerhl opened this issue Sep 8, 2021 · 11 comments
Assignees
Labels
feature-request Request for new features or functionality interactive-window Impacts interactive window notebook-liveshare

Comments

@joyceerhl
Copy link
Contributor

Some people are still trying to use this microsoft/live-share#4032 (comment)

@TamirShklaz
Copy link

+1 would really like this feature :)

@rchiodo
Copy link
Contributor

rchiodo commented Oct 26, 2021

This wouldn't likely be something the jupyter extension actually contributes. I believe it's entirely a live share thing.

@lostintangent
Copy link
Member

Just to confirm: the previous interactive window was a Python extension feature? But now, the interactive window is a built-in primitive of VS Code? If so, then we may need to think through the APIs that Live Share would need to actually remote the context of this experience. Who would be the best person to connect with on that?

@rchiodo
Copy link
Contributor

rchiodo commented Oct 27, 2021

Yes the previous interactive window was a jupyter extension feature. We used the live share APIs to mimic execution across to the guest.

The new interactive window is a core component of VS code now. It's made up of a notebook and a standalone monaco editor. I'd imagine you'd only need to remote the notebook part (at least to start with).

@rebornix or me would be good people to talk to.

@lostintangent
Copy link
Member

Live Share is already working on remoting the notebook experience, but it sounds like the interactive window is a separate component?

@rchiodo
Copy link
Contributor

rchiodo commented Oct 27, 2021

Yeah technically under the covers it's a notebook, but it's registered with different schemes and doesn't end up in the list of 'notebooks'.

@lostintangent
Copy link
Member

I see. As long as Live Share could discover, inspect and "re-play" the actions of an interactive window notebook, then we should be able to add support for this 👍🏼

@rebornix Do you know whether there are already APIs that would allow Live Share to support this? Or do we need to brainstorm the new requirements?

// CC @daytonellwanger

@rebornix
Copy link
Member

Under the hood the interactive window is a notebook + a text editor, and we can use the normal notebook API to drive its execution. It means it won't add too much work to get it working but right now we use API commands to create interactive window, instead of API, not so sure if it meets all requirements but we can explore @lostintangent

@janyas188
Copy link

janyas188 commented Mar 21, 2022

hi,

I was just wondering if this feature is likely to be bought back soon? I was hoping to use this feature to share an interactive window in my current project and would also be useful in other future projects?

@rchiodo
Copy link
Contributor

rchiodo commented Mar 21, 2022

@janyas188 I recommend commenting on the liveshare issue. We (the jupyter team) would likely not be implementing this.

@greazer greazer added feature-request Request for new features or functionality and removed enhancement labels May 4, 2022
@MSA8D8
Copy link

MSA8D8 commented Dec 22, 2022

I have the same issue here. microsoft/live-share#4032

This interactive window is really useful for me to write Python script.
So, I wish you could do something to solve this.

The link rchiodo shared was no longer accessible
https://github.com/microsoft/vssaas-planning/issues/5898

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality interactive-window Impacts interactive window notebook-liveshare
Projects
None yet
Development

No branches or pull requests

10 participants