-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run by line shouldn't be allowed if kernel is busy. And vice-versa. #7740
Labels
Milestone
Comments
DonJayamanne
added
bug
Issue identified by VS Code Team member as probable bug
notebook-run-by-line
labels
Sep 29, 2021
9 tasks
This is basically what's behind #7638, as far as i can tell |
Dupe of #7638 |
greazer
changed the title
Run by line should wait for pending cell executions to complete
Run by line shouldn't be allowed if kernel is busy. And vice-versa.
Sep 30, 2021
If #7697 is a golden scenario, then this is also a golden scenario, as they are the exact same workflow |
Seems to be properly queued now |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Run a long running cell or run the entire notebook and then start run by line.
We need to ensure we handle these cases.
Since run by line will send code directly to the kernel and bypass the cell execution queue.
E.g. if you have 10 cells and run all, then for the last cell we hit
RBL
, then the last cell could start debugging immediately after the first cell has completed.I think we need to add a method
executeHidden
into the KernelExecution class so that it uses the queue & debugging starts after all queued cells have been completed.Should be an easy enough fix, else we end up in a very weird spot.
The text was updated successfully, but these errors were encountered: