Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run by line shouldn't be allowed if kernel is busy. And vice-versa. #7740

Closed
Tracked by #5607
DonJayamanne opened this issue Sep 29, 2021 · 4 comments
Closed
Tracked by #5607
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug notebook-debugging notebook-run-by-line

Comments

@DonJayamanne
Copy link
Contributor

Run a long running cell or run the entire notebook and then start run by line.
We need to ensure we handle these cases.

Since run by line will send code directly to the kernel and bypass the cell execution queue.
E.g. if you have 10 cells and run all, then for the last cell we hit RBL, then the last cell could start debugging immediately after the first cell has completed.

I think we need to add a method executeHidden into the KernelExecution class so that it uses the queue & debugging starts after all queued cells have been completed.
Should be an easy enough fix, else we end up in a very weird spot.

@DonJayamanne DonJayamanne added bug Issue identified by VS Code Team member as probable bug notebook-run-by-line labels Sep 29, 2021
@DavidKutu DavidKutu self-assigned this Sep 29, 2021
@roblourens
Copy link
Member

This is basically what's behind #7638, as far as i can tell

@greazer
Copy link
Member

greazer commented Sep 30, 2021

Dupe of #7638

@greazer greazer closed this as completed Sep 30, 2021
@greazer greazer reopened this Sep 30, 2021
@greazer greazer changed the title Run by line should wait for pending cell executions to complete Run by line shouldn't be allowed if kernel is busy. And vice-versa. Sep 30, 2021
@greazer greazer added this to the October 2021 milestone Sep 30, 2021
@DonJayamanne
Copy link
Contributor Author

If #7697 is a golden scenario, then this is also a golden scenario, as they are the exact same workflow

@rchiodo rchiodo added this to the February 2022 milestone Jan 25, 2022
@greazer greazer modified the milestones: February 2022, On Deck Feb 4, 2022
@roblourens
Copy link
Member

Seems to be properly queued now

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug notebook-debugging notebook-run-by-line
Projects
None yet
Development

No branches or pull requests

5 participants