Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make error output collapsed by default (Was: Ugly output when clicking Stop Cell Execution) #7764

Closed
Tracked by #5607
joaomoreno opened this issue Sep 30, 2021 · 6 comments
Assignees
Labels
feature-request Request for new features or functionality notebook-output
Milestone

Comments

@joaomoreno
Copy link
Member

Testing microsoft/vscode#133905

  1. Put a breakpoint
  2. Start debugging
  3. Click the stop button Stop Cell Execution

The cell output will contain a pretty large scary KeyboardInterrupt message.

image

@greazer greazer added needs-triage papercut 🩸 Something affecting the productivity of the team notebook-run-by-line notebook-debugging bug Issue identified by VS Code Team member as probable bug and removed needs-triage labels Sep 30, 2021
@greazer greazer added this to the October 2021 milestone Sep 30, 2021
@greazer
Copy link
Member

greazer commented Sep 30, 2021

Let's consider making the callstack collapsed by default. Some users may find the stack interesting, some may not. This would be true for ANY error that has a callstack.

@greazer greazer changed the title Ugly output when clicking Stop Cell Execution Make error output collapsed by default (Was: Ugly output when clicking Stop Cell Execution) Sep 30, 2021
@roblourens
Copy link
Member

roblourens commented Sep 30, 2021

Meaning just collapse the output container? @DavidKutu I don't see how that fixes #7696

This would be true for ANY error that has a callstack.

I think errors coming from my code are pretty relevant, but an error from an interrupt is not very interesting

@DavidKutu
Copy link

It will help, but I guess its different enough

@roblourens
Copy link
Member

@rebornix can we do anything here with the custom error renderer? Or would we want to detect this messy error and rewrite it in the jupyter extension?

@roblourens
Copy link
Member

roblourens commented Dec 8, 2022

Like I think that just using a shorter line limit for this particular error would help, so the library frames get truncated off the end, but not sure where that logic would happen.

@DonJayamanne DonJayamanne added notebook-output feature-request Request for new features or functionality and removed bug Issue identified by VS Code Team member as probable bug papercut 🩸 Something affecting the productivity of the team notebook-run-by-line notebook-debugging notebook-execution labels Dec 13, 2023
@amunger
Copy link
Contributor

amunger commented Dec 13, 2023

closing in favor of microsoft/vscode#200253

@amunger amunger closed this as not planned Won't fix, can't repro, duplicate, stale Dec 13, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality notebook-output
Projects
None yet
Development

No branches or pull requests

6 participants