Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Language Server Quick Fix Enhancement (if no kernel selected) #7788

Closed
claudiaregio opened this issue Oct 3, 2021 · 3 comments
Closed

Language Server Quick Fix Enhancement (if no kernel selected) #7788

claudiaregio opened this issue Oct 3, 2021 · 3 comments
Labels
feature-request Request for new features or functionality notebook-execution Kernels issues (start/restart/switch/execution, install ipykernel) notebook-intellisense Intellisense & other language features in notebook cells for any language verification-needed Verification of issue is requested verified Verification succeeded
Milestone
August 2022

Comments

@claudiaregio
Copy link
Contributor

Filing this issue here for now...

I created a new notebook and started working in the cells. I immediately got diagnostics for the packages I wanted to grab since I had not yet selected a kernel. Pylance shows there are no quick fixes available, but it would be nice if the quick fixes could detect a kernel had not yet been selected for the notebook and asked me to select one, especially if the diagnostics are coming from import lines.

image
@rchiodo rchiodo added notebook-intellisense Intellisense & other language features in notebook cells for any language notebook-execution Kernels issues (start/restart/switch/execution, install ipykernel) and removed needs-triage labels Oct 4, 2021
@rchiodo rchiodo added this to the October 2021 milestone Oct 4, 2021
@rchiodo
Copy link
Contributor

rchiodo commented Oct 4, 2021

#6333 should alleviate this somewhat

@rchiodo rchiodo mentioned this issue Oct 13, 2021
Closed
23 tasks
@rchiodo rchiodo modified the milestones: October 2021, November 2021 Oct 27, 2021
@rchiodo rchiodo modified the milestones: November 2021, January 2022 Dec 6, 2021
@rchiodo rchiodo removed this from the January 2022 milestone Jan 25, 2022
@greazer greazer added feature-request Request for new features or functionality and removed enhancement labels May 4, 2022
@DonJayamanne DonJayamanne added this to the August 2022 milestone Aug 2, 2022
@DonJayamanne
Copy link
Contributor

Closing this issue so it gets validated in the august

@rzhao271 rzhao271 added the verification-needed Verification of issue is requested label Aug 23, 2022
@DonJayamanne DonJayamanne added the verified Verification succeeded label Aug 24, 2022
@DonJayamanne
Copy link
Contributor

Marking as verified as we always end up selecting a kernel no matter what, and user can change this if we get erroneous error messages

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
feature-request Request for new features or functionality notebook-execution Kernels issues (start/restart/switch/execution, install ipykernel) notebook-intellisense Intellisense & other language features in notebook cells for any language verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
August 2022
Development

No branches or pull requests
5 participants
@DonJayamanne @rzhao271 @greazer @claudiaregio @rchiodo