Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Per kernel language server for jupyter notebooks #8031

Closed
2 tasks done
rchiodo opened this issue Oct 25, 2021 · 0 comments
Closed
2 tasks done

Test: Per kernel language server for jupyter notebooks #8031

rchiodo opened this issue Oct 25, 2021 · 0 comments
Assignees
Labels
testplan-item verified Verification succeeded

Comments

@rchiodo
Copy link
Contributor

rchiodo commented Oct 25, 2021

Refs: #6333

Complexity: 3

Create Issue


Intellisense in notebooks was originally provided by the python extension. We've made a change to have it provided by the jupyter extension so that we can have 'kernel' specific intellisense. This means if you select a kernel in a notebook, the packages that are parsed depend upon which kernel you pick.

Setup steps:

  1. Install some version of python
  2. Make sure you have pip installed
  3. Install Jupyter extension from marketplace (it has insiders only versions)
  4. Install insiders Python extension

Test steps:

  1. Create two python environments using either venv or conda. Alternatively you can use an existing environment.
  2. Install pandas and numpy into one of the environments but not the other
  3. Open VS code in a new folder (if using venv, make sure the venvs you created are located at the same root)
  4. Create a notebook
  5. Add a cell like so at the top:
import numpy as np
import pandas as pd
  1. Add another cell like so:
df = pd.DataFrame(np.arange(100).reshape(10, -1))
  1. Try switching kernels.
  2. Depending upon which kernel you have selected, there should be diagnostic errors on the numpy and pandas lines.
  3. Try adding more cells
  4. Make sure if you switch you don't get duplicate diag errors on any cells.
@rchiodo rchiodo added the bug Issue identified by VS Code Team member as probable bug label Oct 25, 2021
@rchiodo rchiodo added testplan-item and removed bug Issue identified by VS Code Team member as probable bug needs-triage labels Oct 25, 2021
@ghost ghost assigned alexdima and greazer Oct 26, 2021
@alexdima alexdima removed their assignment Oct 26, 2021
@greazer greazer closed this as completed Oct 26, 2021
@greazer greazer added the verified Verification succeeded label Oct 26, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
testplan-item verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants