Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a concat doc that listens to LSP events to modify itself #8075

Closed
rchiodo opened this issue Oct 27, 2021 · 3 comments
Closed

Create a concat doc that listens to LSP events to modify itself #8075

rchiodo opened this issue Oct 27, 2021 · 3 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority notebook-intellisense Intellisense & other language features in notebook cells for any language verified Verification succeeded
Milestone

Comments

@rchiodo
Copy link
Contributor

rchiodo commented Oct 27, 2021

Replace the current notebook concat document with an implementation that can be shared with pylance.

@rchiodo rchiodo added the bug Issue identified by VS Code Team member as probable bug label Oct 27, 2021
@rchiodo
Copy link
Contributor Author

rchiodo commented Oct 27, 2021

Start in jupyter extension. Overlapping period might switch to npm module.

@greazer greazer added debt Code quality issues notebook-intellisense Intellisense & other language features in notebook cells for any language and removed needs-triage debt Code quality issues labels Oct 28, 2021
@greazer greazer added this to the November 2021 milestone Oct 28, 2021
@greazer greazer added the important Issue identified as high-priority label Oct 28, 2021
@rchiodo
Copy link
Contributor Author

rchiodo commented Nov 10, 2021

This is essentially complete. Implementation resides here:
https://github.com/microsoft/vscode-jupyter-lsp-middleware/blob/88a75b1b17118604ba30c30f98fbf113b0f540a9/src/notebookConcatDocument.ts#L36

It will likely change as I fix bugs and such but should be portable now.

@rchiodo rchiodo closed this as completed Nov 10, 2021
@rchiodo
Copy link
Contributor Author

rchiodo commented Nov 10, 2021

Verification steps:

  • Open a notebook
  • Verify semantic colorization happens
  • Verify hover works
  • Edit cells/Move cells/Delete cells
  • Verify diagnostics are as expected (as if the contents of all python cells were concatenated together)

@rchiodo rchiodo self-assigned this Dec 1, 2021
@lramos15 lramos15 added the verified Verification succeeded label Dec 3, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority notebook-intellisense Intellisense & other language features in notebook cells for any language verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants