-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move installation of all DS packages into Jupyter Extension #8457
Comments
The downside I see is any changes we need because conda changes, we'll be duplicating what Python is doing. Unless they stop doing this altogether, seems like we should make an npm module for this? |
Not that this should influence our choice totally. But does the python extension want to own this type of thing (package installing) for the VS Code python extension ecosystem? If they do then it might be worth trying to solve problems there in the python extension. If they don't (and this was more exposed just for our team) then sure why not do this ourselves? |
Python will be removing all code related to installation, hence there won't be much duplication. I agree, we can create an npm module, as part of this. shoudl be super easy & i propose we create that npm in this same repo. |
I thought they don't want to own this. Again, the only duplication is literally a few lines of code. |
Again, I don't think there's any code duplication, but totally fine with the npm module. |
Suggestion
conda install ipykernel
ourselves (we have the location for conda, etc)This should fix a number of ipykernel installation issues as well.
Benefits
The text was updated successfully, but these errors were encountered: