Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VegasFusion doesn't work #8834

Closed
rchiodo opened this issue Jan 28, 2022 · 5 comments
Closed

VegasFusion doesn't work #8834

rchiodo opened this issue Jan 28, 2022 · 5 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug ipywidgets Rendering, loading, saving, anything to do with IPyWidgets verified Verification succeeded
Milestone

Comments

@rchiodo
Copy link
Contributor

rchiodo commented Jan 28, 2022

This prevents the python package the user has in the kernel from actually working correctly.

Recent example:
https://medium.com/@jonmmease/announcing-vegafusion-570f62207ba7

This doesn't work in our notebooks (likely because we ship our own version of vegas).

The python installed js file should work and if it needs something specific to jupyter, we could always polyfill it.

@rchiodo rchiodo added the bug Issue identified by VS Code Team member as probable bug label Jan 28, 2022
@DonJayamanne
Copy link
Contributor

DonJayamanne commented Jan 31, 2022

Looks like a different issue. I say this because the shipped copy isn't used at all, instead the scripts are downloaded from unpkg as they are ipywidgets.
I can see that the right files including the WASM files are all loaded from unpng (see below)
& from what I can tell unpkg has the latest version.

653, 654.js *.was are all downloaded as a result of this widget (vegafusion).

image

Other similar issues (loading scripts form nbextensions folder and this folder changes for jupyter lab):

@greazer greazer changed the title Stop shipping plotly and vegas (use pypi installed js instead) VegasFusion doesn't work Jan 31, 2022
@greazer greazer added ipywidgets Rendering, loading, saving, anything to do with IPyWidgets and removed needs-triage labels Jan 31, 2022
@DonJayamanne DonJayamanne self-assigned this Jun 6, 2022
@DonJayamanne DonJayamanne added this to the June 2022 milestone Jun 16, 2022
@DonJayamanne
Copy link
Contributor

Fixed

@rchiodo
Copy link
Contributor Author

rchiodo commented Jun 30, 2022

@DonJayamanne do you have verification steps for this?

@rchiodo rchiodo added the verification-steps-needed Steps to verify are needed for verification label Jun 30, 2022
@rebornix rebornix added verified Verification succeeded and removed verified Verification succeeded labels Jul 1, 2022
@rchiodo
Copy link
Contributor Author

rchiodo commented Jul 1, 2022

Okay I think I attempted something that might be what this was trying to fix. It didn't work.

Here's the notebook I ran:

# %%
%pip install "vegafusion-jupyter[embed]" vega-datasets

# %%
import vegafusion as vf
vf.jupyter.enable()

# %%
import altair as alt
import pandas as pd

# %%
df = pd.read_json('./ipyvega/notebooks/cars.json')

alt.Chart(df).mark_point().encode(
    x='Horsepower',
    y='Miles_per_Gallon',
    color='Origin',
)

(works fine without the vf.jupyte.enable() cell because it just uses altair)

I get nothing in the output.

I have this in the developer tools (which sounds like the original error):

image

@rchiodo rchiodo reopened this Jul 1, 2022
@github-actions github-actions bot added the triage-needed Issue needs to be triaged label Jul 1, 2022
@rchiodo rchiodo added verification-found Issue verification failed and removed verification-steps-needed Steps to verify are needed for verification triage-needed Issue needs to be triaged labels Jul 1, 2022
@DonJayamanne
Copy link
Contributor

Notes:

This does not work with the latest version of vega-fusion 0.6.0, please test with and older version such as 0.4.0
Caused by an upstream issue vega/vegafusion#134 (i.e. latest version doesn't have the right files uploaded to the CDN).

Alternative, disable CDN and this will work

@amunger amunger added verified Verification succeeded and removed verification-found Issue verification failed labels Jul 5, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug ipywidgets Rendering, loading, saving, anything to do with IPyWidgets verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

5 participants