Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor src\ipywidgets out of source folder. It could be an npm package #9337

Closed
Tracked by #8976
rchiodo opened this issue Mar 11, 2022 · 1 comment · Fixed by #9374
Closed
Tracked by #8976

Refactor src\ipywidgets out of source folder. It could be an npm package #9337

rchiodo opened this issue Mar 11, 2022 · 1 comment · Fixed by #9374
Labels
bug Issue identified by VS Code Team member as probable bug debt Code quality issues

Comments

@rchiodo
Copy link
Contributor

rchiodo commented Mar 11, 2022

We never change this section and it just muddies the folder structure as we have ipywidgets in multiple spots
@rchiodo rchiodo added bug Issue identified by VS Code Team member as probable bug debt Code quality issues labels Mar 11, 2022
@rchiodo rchiodo mentioned this issue Mar 11, 2022
Closed
9 tasks
@DonJayamanne
Copy link
Contributor

that's what i proposed back then, however the argument was that having source else where was painful for debugging and the like.

@rchiodo rchiodo mentioned this issue Mar 15, 2022
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Issue identified by VS Code Team member as probable bug debt Code quality issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove ipywidgets from 'src' folder and make an npm package microsoft/vscode-jupyter
3 participants
@DonJayamanne @greazer @rchiodo