Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot resolve starting jupyter if active interpreter doesn't support jupyter #9992

Closed
rchiodo opened this issue May 11, 2022 · 3 comments
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug notebook-getting-started notebook-kernel Kernels issues (start/restart/switch/execution, install ipykernel)

Comments

@rchiodo
Copy link
Contributor

rchiodo commented May 11, 2022

I have an active interpreter that doesn't support jupyter.

I open a notebook and pick an interpreter that does have jupyter.

I try to run (with ZMQ disabled).

I get this:

image

In the picture you can see that I have 'condaEnvTest' selected but then it's saying the 'EmptyVenv' doesn't have jupyter installed. Why is it using 'EmptyVenv', well because it's the active interpreter.

This is because the code here:

public async getUsableJupyterPython(cancelToken?: CancellationToken): Promise<PythonEnvironment | undefined> {

Doesn't allow passing of any kernel information. It should be able to use the currently selected interpreter.

@rchiodo rchiodo added the bug Issue identified by VS Code Team member as probable bug label May 11, 2022
@github-actions github-actions bot added the triage-needed Issue needs to be triaged label May 11, 2022
@IanMatthewHuff IanMatthewHuff added notebook-kernel Kernels issues (start/restart/switch/execution, install ipykernel) notebook-getting-started iteration-candidate and removed triage-needed Issue needs to be triaged labels May 12, 2022
@greazer greazer added this to the July 2022 milestone Jul 6, 2022
@greazer
Copy link
Member

greazer commented Jul 8, 2022

Pulling from iteration-candidate and milestone, due to Ian's review yesterday.

@greazer greazer removed this from the July 2022 milestone Jul 8, 2022
@DonJayamanne
Copy link
Contributor

DonJayamanne commented Jul 8, 2022

Doesn't allow passing of any kernel information. It should be able to use the currently selected interpreter.

i think this should,

  • check interpreter in currently select led kernel
  • then check selected interpret as well

this way if tomorrow python extension changes their code to properly select the interpreter that's active in their terminal, then things will work.
else we will setup end up checking the wrong interpreter all over again.

@DonJayamanne DonJayamanne reopened this Jul 8, 2022
@github-actions github-actions bot added the triage-needed Issue needs to be triaged label Jul 8, 2022
@DonJayamanne DonJayamanne removed the triage-needed Issue needs to be triaged label Jul 8, 2022
@DonJayamanne DonJayamanne self-assigned this Aug 15, 2022
@DonJayamanne DonJayamanne added non-zmq-scenario debt Code quality issues labels Aug 15, 2022
@DonJayamanne DonJayamanne removed the debt Code quality issues label Dec 5, 2022
@DonJayamanne
Copy link
Contributor

Closing this as we have very few users on non-zmq and no one has run into this issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug notebook-getting-started notebook-kernel Kernels issues (start/restart/switch/execution, install ipykernel)
Projects
None yet
Development

No branches or pull requests

4 participants