Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MessageConnection onRequest and onNotification should allow removal of handler #661

Closed
AArnott opened this issue Aug 20, 2020 · 0 comments
Closed
Milestone

Comments

@AArnott
Copy link
Member

AArnott commented Aug 20, 2020

I need to support the scenario of RPC methods that are only exposed for a scoped timeframe. For example, I want to add a handler for $/invokeProxy/0/helloWorld that I can remove later (when object 0 should be garbage collected).

The onRequest and onNotification methods don't currently provide a way to revert the operation. Perhaps they can return an IDisposable?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants