metamodel: Add information about whether a request/notification is sent from the client or the server

[michaelpj]

This would be handy for implementations which treat these kinds of messages differently, e.g. the Haskell implementation uses this to make sure servers don't accidentally register handlers for messages that can't be sent to them.

[dbaeumer]

Makes sense. PR welcome.

[michaelpj]

Great. Just to sketch out the design before I do anything, would something like this be acceptable? Name bikeshedding welcome!

export type MethodSender = 'client' | 'server';

export type Request = {
  ...
  methodSender : MethodSender
  ...
}

export type Notification = {
  ...
  methodSender: MethodSender;
  ...
}

[michaelpj]

Another option: MessageDirection = 'clientToServer' | 'serverToClient'

[dbaeumer]

I would go for direction. We need to consider both as a possible value as well.

[michaelpj]

Okay, sounds good to me. I'll leave both out for now since AFAIK no methods actually need it, but we can always add it later.

[dbaeumer]

Progress can in principal go in both ways.

[michaelpj]

Is it okay for me to just modify the metamodel? Is it still re-generated from the typescript sources?

[michaelpj]

#1007

[michaelpj]

Can we leave this open until the visitor is updated and the information is actually in the metamodel?

[michaelpj]

Ignore me, you did it already! Very quick :)