Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflict tree item is not highlighted #672

Closed
Eskibear opened this issue Jul 27, 2021 · 4 comments
Closed

Conflict tree item is not highlighted #672

Eskibear opened this issue Jul 27, 2021 · 4 comments
Labels
feature-request New feature or request
Milestone

Comments

@Eskibear
Copy link
Member

Eskibear commented Jul 27, 2021

Open https://github.com/spring-projects/spring-petclinic , expand dependencies node.

Why is org.webjars:jquery:2.2.4 not highlighted? In this case with only the conflict items, how do I find out where 2.2.4 is?

image

@Eskibear Eskibear added the feature-request New feature or request label Jul 27, 2021
@ShihanMeng618
Copy link
Contributor

Why is org.webjars:jquery:2.2.4 not highlighted?

Only items that are omitted for conflict are highlighted. It means potential warning. org.webjars:jquery:2.2.4 is an effective dependency but not an omitted one.

In this case with only the conflict items, how do I find out where 2.2.4 is?

It is a good question. And where 2.2.4 is introduced is important information to resolve conflicts. But highlighting is not a good way. Because it may pollute the whole view and bring misunderstandings. We are still working for a better way.
There is a workaround here. VS Code provides filtering on every explorer. When you focus on Maven explorer, you can type keywords directly to filter all items. In this case, you can type jquery to filter and find where 2.2.4 is.

@Eskibear Eskibear added this to the backlog milestone Aug 13, 2021
@Eskibear
Copy link
Member Author

filtering only applies on expanded items, and there's no API to add filters programmatically for the moment.

An option is, we add a command (e.g. go to conflict) to expand the first conflict item. In the case above, we 1) find an 2.2.4 item, 2) expand all parents, 3) focus on it.

@ShihanMeng618
Copy link
Contributor

have tried a go-to-effective command to expand the only one effective item by treeView.reveal(). In the case above, we 1) find the 2.2.4 item, 2) expand all parents, and 3) focus on it.

problems remain:

  1. if there are dependencies with several different versions (e.g. 2.5, 2.6, 2.7), how to go-to-next, or go-back-to-conflict
  2. when using go-to-effective ->exclude way to resolve conflict, need to repeat this action several times until no other versions are in the tree. Thus, set-version-to is a better method for resolving conflicts.

@Eskibear
Copy link
Member Author

Eskibear commented Sep 1, 2021

closed by #716

@Eskibear Eskibear closed this as completed Sep 1, 2021
@Eskibear Eskibear modified the milestones: backlog, 0.34.0 Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants