Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support reportingScope "project" #234

Open
athyuttamre opened this issue Dec 4, 2023 · 1 comment
Open

Support reportingScope "project" #234

athyuttamre opened this issue Dec 4, 2023 · 1 comment
Labels
feature-request Request for new features or functionality needs PR

Comments

@athyuttamre
Copy link

athyuttamre commented Dec 4, 2023

It would be great if this plugin could support a reporting scope of project, which typechecks all files in the current project (defined as the first directory in the tree with a pyproject.toml file).

We have a large monorepo where:

  • file scope is not useful as we need cross-file type checking
  • workspace scope is too broad, making type checking slow, and requiring the entire repo to be type-checkable (sometimes we files that will cause mypy to throw, such as a missing __init__.py file)

I'm not sure if mypy itself supports this kind of scoping, but if not, perhaps this plugin could detect the current project and pass that in as the directory to the mypy command i.e. python -m mypy /path/to/project.

At the same time, it is important that mypy config is respected from the root of the workspace. In monorepos, we tend to have a root pyproject.toml that defines mypy config, and it would be great to respect that.

@karthiknadig karthiknadig added feature-request Request for new features or functionality needs community feedback and removed triage-needed labels Dec 12, 2023
@karthiknadig
Copy link
Member

Thanks for the feature request! We are going to give the community 60 days from when this issue was created to provide 7 👍 upvotes on the opening comment to gauge general interest in this idea. If there's enough upvotes then we will consider this feature request in our future planning. If there's unfortunately not enough upvotes then we will close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality needs PR
Projects
None yet
Development

No branches or pull requests

3 participants