Debt: upstream changes from vscode-node-sqlite3

[deepak1556]

• CodeQL changes 7112bf8 @deepak1556 - Address some CodeQL warnings TryGhost/node-sqlite3#1614
• Type fixes 2a6d60a @bpasero - Added library types file TryGhost/node-sqlite3#1527
• Disable non-throwable exceptions 85456ab @deepak1556 - chore: swallow non-throwable exceptions TryGhost/node-sqlite3#1615
• Extend Sqlite3 error codes 59a82b2 @bpasero - Enable extended SQLite error codes TryGhost/node-sqlite3#1528

[daniellockyer]

Hey @bpasero and @deepak1556 🙂 I'm one of the new maintainers for node-sqlite3 after Ghost took over stewardship of the project.

I wanted to let you know that we're absolutely open to upstreaming your changes. I'm currently working on getting CI fixed up and getting a new release w/ prebuilt binaries but then we should be good to see what can be done.

Note: Ghost actually uses @vscode/sqlite3 after Knex switched to your fork 😛 I'm hopeful we can switch back to the original version 🙂

[kibertoad]

We will switch after new release of sqlite is available :)

[bpasero]

@daniellockyer that is excellent news! we would love to switch then back to the official version ❤️

[daniellockyer]

sqlite3 v5.0.3 has been released 🙂

[daniellockyer]

Hey @bpasero - I've fixed up the repo and it's feeling more stable now. Would you like to rebase your PRs and then we can get them merged 🙂

[bpasero]

Yes will do in our debt week (early June).

[bpasero]

Done, will see for the other two.

[daniellockyer]

@bpasero Thanks for all the PRs 🙂

Q: is there a specific reason that vscode is still using this fork? https://github.com/microsoft/vscode/blob/28e52a46fe8df0c924c881e438e124c05f171b9c/package.json#L68. Is there anything I can do to get it to switch back? Or is it dependent on the pending PRs?

We have a VSCode user reporting a bug when building VScode and I've just discovered it's still using the fork here 🙂

[bpasero]

We plan to drop our fork, but we have currently no available engineering resources to do it. It is not as simple as just changing the library, it is also validating all the changes that went in (including SQLite itself) brings no regressions.

[daniellockyer]

That's understandable 🙂 Let me know if I can help anywhere