Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsaved comments are not persisted #215

Closed
ramya-rao-a opened this issue Aug 15, 2018 · 4 comments
Closed

Unsaved comments are not persisted #215

ramya-rao-a opened this issue Aug 15, 2018 · 4 comments
Labels
feature-request Request for new features or functionality

Comments

@ramya-rao-a
Copy link

  • Open a PR overview
  • Start typing a comment
  • Oh I forgot something, let me look at that file in another editor
  • Come back to the editor that has the PR overview

All of my drafted comment is gone!!!

@jongio
Copy link

jongio commented Sep 12, 2018

Absolutely need this.

  1. Drafts should be persisted automatically
  2. If not Short term roadmap #1, then warn user that comment will be lost.

@bessey
Copy link

bessey commented Nov 15, 2018

I would go further and say without this, the main benefit of this extension; being able to truly explore the codebase while reviewing, is completely undermined. At least on GH I can scroll between PR files while writing a comment, with this extension I can't even look at a single other file!

@RMacfarlane
Copy link
Contributor

@rebornix has fixed this: microsoft/vscode#61757

The fix was in the core of VSCode, so this should work in versions 1.29.0 and up

@jongio
Copy link

jongio commented Dec 10, 2018

I have verified that this is fixed.

Version: 1.30.0-insider (user setup)
Commit: 241923763dbeaf3b64443187e935d55b29f6125d
Date: 2018-12-07T22:31:41.479Z
Electron: 2.0.12
Chrome: 61.0.3163.100
Node.js: 8.9.3
V8: 6.1.534.41
OS: Windows_NT x64 10.0.17134

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

5 participants