Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate view containers for PR and issues list and the active pull request #2371

Closed
RMacfarlane opened this issue Jan 19, 2021 · 3 comments · Fixed by #2483
Closed

Separate view containers for PR and issues list and the active pull request #2371

RMacfarlane opened this issue Jan 19, 2021 · 3 comments · Fixed by #2483
Assignees
Labels
feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@RMacfarlane
Copy link
Contributor

RMacfarlane commented Jan 19, 2021

Right now all views are contributed into the same "GitHub" view container which uses the pull request icon. As we add additional views for "focused mode" and creating a pull request, the management of this view container becomes more of a hassle.

Having a separate viewlet for the currently active pull request makes it easy to go back and reference the pull request or issues list. To do this, we would change the existing view container to use the old GitHub icon (which has already been requested by users), and use the PR icon for the new container.

separate_viewlets

@RMacfarlane RMacfarlane added the feature-request Request for new features or functionality label Jan 19, 2021
@RMacfarlane RMacfarlane added this to the January 2021 milestone Jan 19, 2021
@RMacfarlane RMacfarlane self-assigned this Jan 19, 2021
@mkwng
Copy link

mkwng commented Jan 21, 2021

Is there precedent for extensions using two icons on the sidebar like this? i understand the utility, but i wonder if there's a better way of allowing more focus here.

@misolori are there extension patterns that allow for nesting or moving deeper that can be borrowed here?

@miguelsolorio
Copy link
Contributor

@mkwng we don't have any patterns that extensions can use, in the remote explorer we use a dropdown to switch between views (which has also been requested from extension authors) but that is not part of the extension api. This is a little similar pattern to our References view where a dynamic view appears only when invoked via a command:

image

We also have a concept of moving views around so the user can take any view from an extension and pull it out into it's own view, so this isn't too far from that as well. In the example below, I've taken the "TODO" view and have moved it into the remote explorer view:

image

@RMacfarlane
Copy link
Contributor Author

To verify:

Using the nightly version of the extension

  • start creating a PR, should go to the new pull request viewlet
  • checkout a pull request, should also go the new viewlet

@rzhao271 rzhao271 added the verified Verification succeeded label Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
4 participants