Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve refresh behavior of the PR views #2478

Closed
RMacfarlane opened this issue Feb 8, 2021 · 0 comments · Fixed by #2646
Closed

Improve refresh behavior of the PR views #2478

RMacfarlane opened this issue Feb 8, 2021 · 0 comments · Fixed by #2646
Assignees
@RMacfarlane
Labels
feature-request Request for new features or functionality on-testplan
Milestone
April 2021

Comments

@RMacfarlane
Copy link
Contributor

Currently data within the extension can sometimes get out of sync, two specific examples:

  1. In the extension, you start a review and add some comments inline in editors and submit the review. The PR author responds to them on GitHub.com. If you open the description page from the extension after this, the reply appears on it. The editor comment thread does not update immediately, however - it takes up to 5 minutes for this to poll and refresh even though we should already know there is another comment.
  2. If you have the "focused mode" setting on and you use the "Merge" button there, the view updates, but if you have the description view open, it does not
@RMacfarlane RMacfarlane added the feature-request Request for new features or functionality label Feb 8, 2021
@RMacfarlane RMacfarlane added this to the February 2021 milestone Feb 8, 2021
@RMacfarlane RMacfarlane self-assigned this Feb 8, 2021
@egamma egamma mentioned this issue Feb 9, 2021
Closed
70 tasks
@RMacfarlane RMacfarlane modified the milestones: February 2021, March 2021 Feb 24, 2021
@kieferrm kieferrm mentioned this issue Mar 6, 2021
Closed
76 tasks
@RMacfarlane RMacfarlane modified the milestones: March 2021, April 2021 Mar 22, 2021
@kieferrm kieferrm mentioned this issue Apr 5, 2021
Closed
75 tasks
This was referenced Apr 6, 2021
Merged
Merged
@RMacfarlane RMacfarlane mentioned this issue Apr 26, 2021
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RMacfarlane RMacfarlane

Labels
feature-request Request for new features or functionality on-testplan
Projects
None yet
Milestone
April 2021
Development

Successfully merging a pull request may close this issue.

Fire event when PR is merged so all views can updated microsoft/vscode-pull-request-github
1 participant
@RMacfarlane