Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let me do a proper review that includes many comments #298

Closed
Tyriar opened this issue Aug 28, 2018 · 4 comments
Closed

Let me do a proper review that includes many comments #298

Tyriar opened this issue Aug 28, 2018 · 4 comments
Labels
*duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality

Comments

@Tyriar
Copy link
Member

Tyriar commented Aug 28, 2018

microsoft/vscode#57301

Currently I think we can only leave one off comments and then request changes/approve the PR. Reviews can be dismissed which dismissed several comments, also I always use the top-level review comment to give an overall statement on the PR/review, having these disjointed is much less organized.

@rebornix rebornix added the feature-request Request for new features or functionality label Aug 28, 2018
@jongio
Copy link

jongio commented Sep 12, 2018

This will block me from using the extension. Grouping comments into a review is my main PR review workflow.

@lilyball
Copy link

I agree. I would love to use this extension, but the inability to group comments into a review is a hard dealbreaker. I'm not going to subject my coworkers to 40 emails when I could send them a single email with 40 comments.

@suresh-productiv
Copy link

This is definitely something that is blocking me from using this otherwise wonderful plugin. Any idea when this feature will get picked up?

@rebornix
Copy link
Member

rebornix commented Jan 2, 2019

Let's track this issue in #546, thanks everyone for your feedback.

@rebornix rebornix closed this as completed Jan 2, 2019
@alexr00 alexr00 added *duplicate Issue identified as a duplicate of another issue(s) and removed duplicate labels Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
*duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

6 participants