Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we have to show the repository dropdown for only one repo #4380

Closed
isidorn opened this issue Jan 4, 2023 · 3 comments
Closed

Do we have to show the repository dropdown for only one repo #4380

isidorn opened this issue Jan 4, 2023 · 3 comments
Assignees

Comments

@isidorn
Copy link

isidorn commented Jan 4, 2023

  1. Create a new PR. Notice there are 4 drop-downs.
  2. I believe this makes the view much more complicated than having just 2 drop-downs as GitHub does

Do we show the repository drop-down because there can be multiple repositories in the Workspace?
Does it make sense that we do not show the repository dropdown for Workspaces that have only one repository? I believe this is the majority and would quite simplify the flow. What do you think?

Screenshot 2023-01-04 at 14 33 29

@alexr00
Copy link
Member

alexr00 commented Jan 4, 2023

Do we show the repository drop-down because there can be multiple repositories in the Workspace?

We show the repository drop-down because there can be multiple remotes associated with one folder. OSS contributors will often have at least 2 remotes (their fork and the upstream). Maintainers are more likely to only have 1 remote.

Only showing the remote/repo picker when there's more than one remote makes sense to me.

@alexr00 alexr00 added this to the March 2023 milestone Jan 4, 2023
@isidorn
Copy link
Author

isidorn commented Jan 4, 2023

Thanks for the explanation.

@alexr00
Copy link
Member

alexr00 commented Mar 17, 2023

Duplicate of #4403

@alexr00 alexr00 marked this as a duplicate of #4403 Mar 17, 2023
@alexr00 alexr00 closed this as completed Mar 17, 2023
@alexr00 alexr00 removed this from the March 2023 milestone Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants