Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy GitHub __ Link actions from file/share menu copy links with file paths and line ranges #4598

Open
joyceerhl opened this issue Mar 8, 2023 · 3 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug
Milestone

Comments

@joyceerhl
Copy link
Contributor

  1. Open a GitHub repo with the stable version of GHPRI installed
  2. Open the File > Share menu
  3. Copy GitHub Permalink, Copy GitHub HEAD Link, or Copy GitHub Permalink as Markdown
  4. 🐛 the active file path and line are included

We special-cased the file menu's behavior for copying vscode.dev links in the builtin GitHub extension and the Remote Repositories extensions to not copy the file path or line, so GHPRI's contributions to file/share are inconsistent (this is not a regression from the changes just checked into main). However @rzhao271 and @amunger had feedback that the file/share behavior was not what they expected, I think they expected it to relate to the active editor, in which case we would keep GHPRI's current behavior and change the vscode.dev link behavior.

Whatever we do here we should be consistent across all the copy link commands so I'm opening this issue to discuss the desired behavior.

@joyceerhl joyceerhl added the under-discussion Issue is under discussion for relevance, priority, approach label Mar 8, 2023
@joyceerhl joyceerhl added bug Issue identified by VS Code Team member as probable bug and removed under-discussion Issue is under discussion for relevance, priority, approach labels Mar 10, 2023
@joyceerhl joyceerhl added this to the March 2023 milestone Mar 10, 2023
@alexr00
Copy link
Member

alexr00 commented Mar 14, 2023

@joyceerhl have you come to any conclusions on whether to include the file + line number when using commands from the File > Share menu?

@joyceerhl
Copy link
Contributor Author

I think we should not include the file and line number for now. However there was a good suggestion to consolidate the share submenus as a single contribution point in microsoft/vscode#176316, and if we did this then we'd be able to remove a lot of the duplicated commands in favor of a single command which behaves differently depending on the passed arguments.

@alexr00
Copy link
Member

alexr00 commented Mar 17, 2023

Looks like microsoft/vscode#176316 is in flux. Moving out of the March milestone.

@alexr00 alexr00 modified the milestones: March 2023, On Deck Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Development

No branches or pull requests

2 participants