Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test resolving conflicts on a checked out PR #5648

Closed
3 tasks done
alexr00 opened this issue Jan 22, 2024 · 3 comments
Closed
3 tasks done

Test resolving conflicts on a checked out PR #5648

alexr00 opened this issue Jan 22, 2024 · 3 comments

Comments

@alexr00
Copy link
Member

alexr00 commented Jan 22, 2024

Refs: #1562

Complexity: 4

Create Issue


To test, you'll need to have a PR with merge conflicts. If you have such a PR already, you can skip step 2.

  1. Install the pre-release version of GitHub Pull Requests and Issues
  2. Checkout or make a PR that has merge conflicts. To make a PR with merge conflicts:
    a. Look at what the most recent commit on main has changed. Take note of this.
    b. Do git log and copy the second most recent commit sha
    c. git checkout the-commit-sha-you-copied
    d. git checkout -b topic-branch-name-of-your-choice
    e. Modify the same code that you noted in step a. Commit this and make a PR.
  3. Open the PR's description/overview page.
  4. Verify that you see a button to "Resolve Conflicts". Verify that you only see this button when the PR is checked out.
  5. Use the button to "Resolve Conflicts". Verify that you can resolve the conflicts. Verify that the button from step 4 no longer shows once you're done.
@deepak1556
Copy link

The scroll glitch is making it hard to work with the conflicts view, will wait for it to get fixed.

@anthonykim1
Copy link

anthonykim1 commented Jan 23, 2024

I think it is working for Mac? I tried to record my testing and I didn't see the scroll glitch. See attached

Screen.Recording.2024-01-23.at.10.30.44.AM.mov

Image is after I resolve conflict:
Screenshot 2024-01-23 at 10 34 27 AM

@deepak1556
Copy link

The issue happens depending on the number files involved with conflicts. I was able to test the flow with a PR that had a single file conflict.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants