Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue links in description/comments are not linkified #66

Closed
Tyriar opened this issue Jun 27, 2018 · 5 comments
Closed

Issue links in description/comments are not linkified #66

Tyriar opened this issue Jun 27, 2018 · 5 comments
Labels
description page github Related to GitHub API

Comments

@Tyriar
Copy link
Member

Tyriar commented Jun 27, 2018

See the link at the bottom. repo/user#num format should also be covered

image

@rebornix rebornix added the github Related to GitHub API label Jun 27, 2018
@rebornix
Copy link
Member

related #74

Right now the description we get from GitHub v3 API is plain text (markdown) so we can render the content to HTML but we didn't do any conversion like converting #1518 to https://github.com/${owner}/${repo}/issues/1518, or truncating the label for links.

As we are using Markdown-it, we can customize the markdown rendering to support this or maybe GitHub API can provide content similar to what they already have in web pages.

@Tyriar
Copy link
Member Author

Tyriar commented Jun 27, 2018

@rebornix couldn't you run the markdown through a filter which converts the links before passing it to markdown-it?

@rebornix
Copy link
Member

@Tyriar markdown grammars are ambiguous so writing a markdown-it extension which takes care link token can solve this problem better.

@rebornix
Copy link
Member

rebornix commented Aug 6, 2018

As raised in #105, links in comments are not linkified as well.

@rebornix rebornix added the bug Issue identified by VS Code Team member as probable bug label Aug 6, 2018
@rebornix rebornix changed the title Issue links in description are not linkified Issue links in description/comments are not linkified Aug 6, 2018
@rebornix rebornix removed the bug Issue identified by VS Code Team member as probable bug label Aug 6, 2018
@kieferrm kieferrm removed the github Related to GitHub API label Aug 10, 2018
@rebornix rebornix added the github Related to GitHub API label Aug 14, 2018
@RMacfarlane
Copy link
Contributor

Completed by #831

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
description page github Related to GitHub API
Projects
None yet
Development

No branches or pull requests

4 participants