Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug flow #527

Open
bamurtaugh opened this issue Nov 30, 2021 · 3 comments
Open

Debug flow #527

bamurtaugh opened this issue Nov 30, 2021 · 3 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug needs PR Ready to be worked on

Comments

@bamurtaugh
Copy link
Member

Testing microsoft/vscode-python#18092

  • Open https://github.com/microsoft/vscode-remote-try-python with GitHub Repositories in VS Code desktop
  • Go to Run and Debug
  • If I was new to this flow, I'd want to and wonder how to run my app
    • I think a user would need to continue locally?
    • Could we indicate this in the message and perhaps guide users there via messaging/a button (i.e. to "Continue Working on" locally), rather than saying it's not supported in the current environment and prompting to open the launch.json?

image

image

@joyceerhl @karrtikr @kimadeline Although the test plan item came from the vscode-python repo, I thought this flow may be part of GitHub Repositories and/or debugging overall, so filing here. Please let me know if I should file elsewhere or it's already being tracked/considered. Thank you!

@kimadeline kimadeline removed their assignment Nov 30, 2021
@joyceerhl joyceerhl transferred this issue from microsoft/vscode-remote-repositories-github Mar 7, 2022
@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Mar 7, 2022
@joyceerhl
Copy link

Still repros:
image

Should the Python extension not contribute launch configurations when in a virtual workspace on desktop?

@joyceerhl joyceerhl removed their assignment Mar 7, 2022
@karthiknadig karthiknadig added bug Issue identified by VS Code Team member as probable bug and removed triage-needed Needs assignment to the proper sub-team labels Mar 8, 2022
@karrtikr
Copy link
Contributor

karrtikr commented Mar 8, 2022

This is where we disable the debug configuration view for virtual workspaces if that's relevant: https://github.com/microsoft/vscode-python/blob/983a8dfd4c8eb524614490b2e63bc894a859cb72/package.json#L1509

@brettcannon
Copy link
Member

Do we have the appropriate hooks already to intercept this to suggest people run locally? As Kartik pointed out we can probably disable debugging for virtual workspaces (although it looks like we already do something which is probably what's making the prompt show up to begin with).

@karrtikr karrtikr added the needs PR Ready to be worked on label Aug 9, 2022
@eleanorjboyd eleanorjboyd transferred this issue from microsoft/vscode-python Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug needs PR Ready to be worked on
Projects
None yet
Development

No branches or pull requests

7 participants