Support multi-root folders in test explorer

DonJayamanne · DonJayamanne · commit 64b7e2250c70 · 2019-03-11T11:39:18.000-07:00
diff --git a/news/1 Enhancements/4268.md b/news/1 Enhancements/4268.md
@@ -0,0 +1 @@
+Support mult-root workspaces in test explorer.
diff --git a/package.json b/package.json
@@ -679,6 +679,21 @@
             ],
             "view/item/context": [
                 {
+                    "command": "python.runtests",
+                    "when": "view == python_tests && viewItem == testWorkspaceFolder && !busyTests",
+                    "group": "inline@0"
+                },
+                {
+                    "command": "python.debugtests",
+                    "when": "view == python_tests && viewItem == testWorkspaceFolder && !busyTests",
+                    "group": "inline@1"
+                },
+                {
+                    "command": "python.discoverTests",
+                    "when": "view == python_tests && viewItem == testWorkspaceFolder && !busyTests",
+                    "group": "inline@2"
+                },
+                    {
                     "command": "python.openTestNodeInEditor",
                     "when": "view == python_tests && viewItem == testFunction",
                     "group": "inline@2"
diff --git a/src/client/unittests/common/testUtils.ts b/src/client/unittests/common/testUtils.ts
@@ -5,7 +5,7 @@ import { IApplicationShell, ICommandManager } from '../../common/application/typ
 import * as constants from '../../common/constants';
 import { IUnitTestSettings, Product } from '../../common/types';
 import { IServiceContainer } from '../../ioc/types';
-import { TestDataItem } from '../types';
+import { TestDataItem, TestWorkspaceFolder } from '../types';
 import { CommandSource } from './constants';
 import { TestFlatteningVisitor } from './testVisitors/flatteningVisitor';
 import {
@@ -198,8 +198,7 @@ export class TestsHelper implements ITestsHelper {
         }
 
         // Just return this as a test file.
-        // tslint:disable-next-line:no-object-literal-type-assertion
-        return <TestsToRun>{ testFile: [{ name: name, nameToRun: name, functions: [], suites: [], xmlName: name, fullPath: '', time: 0 }] };
+        return { testFile: [{ resource: Uri.file(rootDirectory), name: name, nameToRun: name, functions: [], suites: [], xmlName: name, fullPath: '', time: 0 }] };
     }
     public displayTestErrorMessage(message: string) {
         this.appShell.showErrorMessage(message, constants.Button_Text_Tests_View_Output).then(action => {
@@ -246,6 +245,9 @@ export class TestsHelper implements ITestsHelper {
 }
 
 export function getTestType(test: TestDataItem): TestType {
+    if (test instanceof TestWorkspaceFolder) {
+        return TestType.testWorkspaceFolder;
+    }
     if (getTestFile(test)) {
         return TestType.testFile;
     }
diff --git a/src/client/unittests/common/types.ts b/src/client/unittests/common/types.ts
@@ -43,7 +43,8 @@ export enum TestType {
     testFile = 'testFile',
     testFolder = 'testFolder',
     testSuite = 'testSuite',
-    testFunction = 'testFunction'
+    testFunction = 'testFunction',
+    testWorkspaceFolder = 'testWorkspaceFolder'
 }
 export type TestFile = TestResult & {
     resource: Uri;
diff --git a/src/client/unittests/explorer/testTreeViewItem.ts b/src/client/unittests/explorer/testTreeViewItem.ts
@@ -5,38 +5,15 @@
 
 // tslint:disable:max-classes-per-file
 
-import { ThemeIcon, TreeItem, TreeItemCollapsibleState, Uri, WorkspaceFolder } from 'vscode';
+import { ThemeIcon, TreeItem, TreeItemCollapsibleState, Uri } from 'vscode';
 import { Commands } from '../../common/constants';
 import { getIcon } from '../../common/utils/icons';
 import { noop } from '../../common/utils/misc';
 import { Icons } from '../common/constants';
 import { getTestType } from '../common/testUtils';
-import { TestFile, TestStatus, TestType } from '../common/types';
+import { TestStatus, TestType } from '../common/types';
 import { TestDataItem } from '../types';
 
-export class TestWorkspaceFolder {
-    constructor(public readonly workspaceFolder: WorkspaceFolder) { }
-    public get resource(): Uri {
-        return this.workspaceFolder.uri;
-    }
-}
-
-export class TestWorkspaceFolderTreeItem extends TreeItem {
-    constructor(
-        public readonly resource: Uri,
-        public readonly data: Readonly<TestWorkspaceFolder>,
-        label: string
-    ) {
-        super(label, TreeItemCollapsibleState.Collapsed);
-    }
-    public get contextValue(): string {
-        return 'workspaceFolder';
-    }
-    public get iconPath(): string | Uri | { light: string | Uri; dark: string | Uri } | ThemeIcon {
-        return ThemeIcon.Folder;
-    }
-}
-
 /**
  * Class that represents a visual node on the
  * Test Explorer tree view. Is essentially a wrapper for the underlying
@@ -47,21 +24,23 @@ export class TestTreeItem extends TreeItem {
 
     constructor(
         public readonly resource: Uri,
-        public readonly data: Readonly<TestDataItem>,
-        private readonly parentData: TestWorkspaceFolder | TestDataItem
+        public readonly data: Readonly<TestDataItem>
     ) {
-        super(data.name, TreeItemCollapsibleState.Collapsed);
+        super(data.name, TestTreeItem.getCollapsibleState(data));
         this.testType = getTestType(this.data);
         this.setCommand();
-        if (this.testType === TestType.testFile) {
-            this.resourceUri = Uri.file((this.data as TestFile).fullPath);
-        }
+    }
+    private static getCollapsibleState(data: TestDataItem): TreeItemCollapsibleState {
+        return getTestType(data) === TestType.testFunction ? TreeItemCollapsibleState.None : TreeItemCollapsibleState.Collapsed;
     }
     public get contextValue(): string {
         return this.testType;
     }
 
     public get iconPath(): string | Uri | { light: string | Uri; dark: string | Uri } | ThemeIcon {
+        if (this.testType === TestType.testWorkspaceFolder) {
+            return ThemeIcon.Folder;
+        }
         if (!this.data) {
             return '';
         }
@@ -79,27 +58,10 @@ export class TestTreeItem extends TreeItem {
                 return getIcon(Icons.discovering);
             }
             default: {
-                switch (this.testType) {
-                    case TestType.testFile: {
-                        return ThemeIcon.File;
-                    }
-                    case TestType.testFolder: {
-                        return ThemeIcon.Folder;
-                    }
-                    default: {
-                        return getIcon(Icons.unknown);
-                    }
-                }
+                return getIcon(Icons.unknown);
             }
         }
     }
-    /**
-     * Parent is an extension to the TreeItem, to make it trivial to discover the node's parent.
-     */
-    public get parent(): TestWorkspaceFolder | TestDataItem {
-        return this.parentData;
-    }
-
     /**
      * Tooltip for our tree nodes is the test status
      */
@@ -127,14 +89,3 @@ export class TestTreeItem extends TreeItem {
         }
     }
 }
-
-/**
- * Create a TreView node from a given TestDataItem without having to specify the exact test item type.
- *
- * @param resource The workspace resource that this test item exists within.
- * @param testData The data item being represented in this tree view node.
- * @param parent The parent (or undefined, if the item is a root folder) of the test item.
- */
-export function createTreeViewItemFrom(resource: Uri, testData: Readonly<TestDataItem>, parent?: TestWorkspaceFolder | TestDataItem): TreeItem {
-    return new TestTreeItem(resource, testData, parent!);
-}
diff --git a/src/client/unittests/explorer/testTreeViewProvider.ts b/src/client/unittests/explorer/testTreeViewProvider.ts
@@ -9,15 +9,15 @@ import { IWorkspaceService } from '../../common/application/types';
 import { IDisposable, IDisposableRegistry } from '../../common/types';
 import { getChildren, getParent } from '../common/testUtils';
 import { ITestCollectionStorageService, TestStatus } from '../common/types';
-import { ITestDataItemResource, ITestTreeViewProvider, IUnitTestManagementService, TestDataItem, WorkspaceTestStatus } from '../types';
-import { createTreeViewItemFrom, TestWorkspaceFolder, TestWorkspaceFolderTreeItem } from './testTreeViewItem';
+import { ITestDataItemResource, ITestTreeViewProvider, IUnitTestManagementService, TestDataItem, TestWorkspaceFolder, WorkspaceTestStatus } from '../types';
+import { TestTreeItem } from './testTreeViewItem';
 
 @injectable()
-export class TestTreeViewProvider implements ITestTreeViewProvider<TestWorkspaceFolder | TestDataItem>, ITestDataItemResource, IDisposable {
-    public readonly onDidChangeTreeData: Event<TestWorkspaceFolder | TestDataItem | undefined>;
+export class TestTreeViewProvider implements ITestTreeViewProvider, ITestDataItemResource, IDisposable {
+    public readonly onDidChangeTreeData: Event<TestDataItem | undefined>;
     public readonly testsAreBeingDiscovered: Map<string, boolean>;
 
-    private _onDidChangeTreeData = new EventEmitter<TestWorkspaceFolder | TestDataItem | undefined>();
+    private _onDidChangeTreeData = new EventEmitter<TestDataItem | undefined>();
     private disposables: IDisposable[] = [];
 
     constructor(
@@ -46,7 +46,7 @@ export class TestTreeViewProvider implements ITestTreeViewProvider<TestWorkspace
      * @param testData Test data item to map to a Uri
      * @returns A Uri representing the workspace that the test data item exists within
      */
-    public getResource(testData: Readonly<TestWorkspaceFolder | TestDataItem>): Uri {
+    public getResource(testData: Readonly<TestDataItem>): Uri {
         return testData.resource;
     }
 
@@ -65,12 +65,8 @@ export class TestTreeViewProvider implements ITestTreeViewProvider<TestWorkspace
      * @param element The element for which [TreeItem](#TreeItem) representation is asked for.
      * @return [TreeItem](#TreeItem) representation of the element
      */
-    public async getTreeItem(element: TestWorkspaceFolder | TestDataItem): Promise<TreeItem> {
-        if (element instanceof TestWorkspaceFolder) {
-            return new TestWorkspaceFolderTreeItem(element.resource, element, element.workspaceFolder.name);
-        }
-        const parent = await this.getParent!(element);
-        return createTreeViewItemFrom(element.resource, element, parent);
+    public async getTreeItem(element: TestDataItem): Promise<TreeItem> {
+        return new TestTreeItem(element.resource, element);
     }
 
     /**
@@ -79,23 +75,30 @@ export class TestTreeViewProvider implements ITestTreeViewProvider<TestWorkspace
      * @param element The element from which the provider gets children. Can be `undefined`.
      * @return Children of `element` or root if no element is passed.
      */
-    public getChildren(element?: TestWorkspaceFolder | TestDataItem): TestWorkspaceFolder[] | TestDataItem[] {
-        if (!element && Array.isArray(this.workspace.workspaceFolders) && this.workspace.workspaceFolders.length > 0) {
-            return this.workspace.workspaceFolders
-                .filter(workspaceFolder => this.testStore.getTests(workspaceFolder.uri))
-                .map(workspaceFolder => new TestWorkspaceFolder(workspaceFolder));
-        }
-        if (element instanceof TestWorkspaceFolder) {
-            const tests = this.testStore.getTests(element.workspaceFolder.uri);
-            return tests ? tests.rootTestFolders : [];
-        } else {
-            const tests = this.testStore.getTests(element.resource);
-            if (element === undefined) {
-                return tests && tests.testFolders ? tests.rootTestFolders : [];
+    public getChildren(element?: TestDataItem): TestDataItem[] {
+        if (element) {
+            if (element instanceof TestWorkspaceFolder) {
+                const tests = this.testStore.getTests(element.workspaceFolder.uri);
+                return tests ? tests.rootTestFolders : [];
             }
+            return getChildren(element!);
+        }
 
-            return getChildren(element);
+        if (!Array.isArray(this.workspace.workspaceFolders) || this.workspace.workspaceFolders.length === 0) {
+            return [];
         }
+
+        // If we are in a single workspace
+        if (this.workspace.workspaceFolders.length === 1) {
+            const tests = this.testStore.getTests(this.workspace.workspaceFolders[0].uri);
+            return tests ? tests.rootTestFolders : [];
+        }
+
+        // If we are in a mult-root workspace, then nest the test data within a
+        // virtual node, represending the workspace folder.
+        return this.workspace.workspaceFolders
+            .filter(workspaceFolder => this.testStore.getTests(workspaceFolder.uri))
+            .map(workspaceFolder => new TestWorkspaceFolder(workspaceFolder));
     }
 
     /**
@@ -107,12 +110,12 @@ export class TestTreeViewProvider implements ITestTreeViewProvider<TestWorkspace
      * @param element The element for which the parent has to be returned.
      * @return Parent of `element`.
      */
-    public async getParent?(element: TestWorkspaceFolder | TestDataItem): Promise<TestWorkspaceFolder | TestDataItem> {
+    public async getParent(element: TestDataItem): Promise<TestDataItem | undefined> {
         if (element instanceof TestWorkspaceFolder) {
             return;
         }
         const tests = this.testStore.getTests(element.resource);
-        return tests ? getParent(tests, element)! : undefined;
+        return tests ? getParent(tests, element) : undefined;
     }
 
     /**
diff --git a/src/client/unittests/main.ts b/src/client/unittests/main.ts
@@ -34,9 +34,12 @@ import {
 import {
     ITestDisplay, ITestResultDisplay, ITestTreeViewProvider,
     IUnitTestConfigurationService, IUnitTestManagementService,
+    TestWorkspaceFolder,
     WorkspaceTestStatus
 } from './types';
 
+// tslint:disable:no-any
+
 @injectable()
 export class UnitTestManagementService implements IUnitTestManagementService, Disposable {
     private readonly outputChannel: OutputChannel;
@@ -78,8 +81,7 @@ export class UnitTestManagementService implements IUnitTestManagementService, Di
         this.registerHandlers();
         this.registerCommands();
 
-        // tslint:disable-next-line:no-any
-        const testViewProvider = this.serviceContainer.get<ITestTreeViewProvider<any>>(ITestTreeViewProvider);
+        const testViewProvider = this.serviceContainer.get<ITestTreeViewProvider>(ITestTreeViewProvider);
         const disposable = window.registerTreeDataProvider('python_tests', testViewProvider);
         disposablesRegistry.push(disposable);
 
@@ -354,7 +356,10 @@ export class UnitTestManagementService implements IUnitTestManagementService, Di
         const commandManager = this.serviceContainer.get<ICommandManager>(ICommandManager);
 
         const disposables = [
-            commandManager.registerCommand(constants.Commands.Tests_Discover, (_, cmdSource: CommandSource = CommandSource.commandPalette, resource?: Uri) => {
+            commandManager.registerCommand(constants.Commands.Tests_Discover, (treeNode: TestWorkspaceFolder | any, cmdSource: CommandSource = CommandSource.commandPalette, resource?: Uri) => {
+                if (treeNode && treeNode instanceof TestWorkspaceFolder) {
+                    resource = treeNode.resource;
+                }
                 // Ignore the exceptions returned.
                 // This command will be invoked from other places of the extension.
                 this.discoverTests(cmdSource, resource, true, true)
@@ -367,8 +372,18 @@ export class UnitTestManagementService implements IUnitTestManagementService, Di
                     .ignoreErrors();
             }),
             commandManager.registerCommand(constants.Commands.Tests_Run_Failed, (_, cmdSource: CommandSource = CommandSource.commandPalette, resource: Uri) => this.runTestsImpl(cmdSource, resource, undefined, true)),
-            commandManager.registerCommand(constants.Commands.Tests_Run, (_, cmdSource: CommandSource = CommandSource.commandPalette, file: Uri, testToRun?: TestsToRun) => this.runTestsImpl(cmdSource, file, testToRun)),
-            commandManager.registerCommand(constants.Commands.Tests_Debug, (_, cmdSource: CommandSource = CommandSource.commandPalette, file: Uri, testToRun: TestsToRun) => this.runTestsImpl(cmdSource, file, testToRun, false, true)),
+            commandManager.registerCommand(constants.Commands.Tests_Run, (treeNode: TestWorkspaceFolder | any, cmdSource: CommandSource = CommandSource.commandPalette, resource?: Uri, testToRun?: TestsToRun) => {
+                if (treeNode && treeNode instanceof TestWorkspaceFolder) {
+                    resource = treeNode.resource;
+                }
+                return this.runTestsImpl(cmdSource, resource, testToRun);
+            }),
+            commandManager.registerCommand(constants.Commands.Tests_Debug, (treeNode: TestWorkspaceFolder | any, cmdSource: CommandSource = CommandSource.commandPalette, resource: Uri, testToRun: TestsToRun) => {
+                if (treeNode && treeNode instanceof TestWorkspaceFolder) {
+                    resource = treeNode.resource;
+                }
+                return this.runTestsImpl(cmdSource, resource, testToRun, false, true);
+            }),
             commandManager.registerCommand(constants.Commands.Tests_View_UI, () => this.displayUI(CommandSource.commandPalette)),
             commandManager.registerCommand(constants.Commands.Tests_Picker_UI, (_, cmdSource: CommandSource = CommandSource.commandPalette, file: Uri, testFunctions: TestFunction[]) => this.displayPickerUI(cmdSource, file, testFunctions)),
             commandManager.registerCommand(constants.Commands.Tests_Picker_UI_Debug, (_, cmdSource: CommandSource = CommandSource.commandPalette, file: Uri, testFunctions: TestFunction[]) => this.displayPickerUI(cmdSource, file, testFunctions, true)),
diff --git a/src/client/unittests/serviceRegistry.ts b/src/client/unittests/serviceRegistry.ts
@@ -106,8 +106,7 @@ export function registerTypes(serviceManager: IServiceManager) {
 
     serviceManager.addSingleton<IUnitTestDiagnosticService>(IUnitTestDiagnosticService, UnitTestDiagnosticService);
     serviceManager.addSingleton<ITestMessageService>(ITestMessageService, TestMessageService, PYTEST_PROVIDER);
-    // tslint:disable-next-line:no-any
-    serviceManager.addSingleton<ITestTreeViewProvider<any>>(ITestTreeViewProvider, TestTreeViewProvider);
+    serviceManager.addSingleton<ITestTreeViewProvider>(ITestTreeViewProvider, TestTreeViewProvider);
     serviceManager.addSingleton<ITestDataItemResource>(ITestDataItemResource, TestTreeViewProvider);
     serviceManager.addSingleton<ITestExplorerCommandHandler>(ITestExplorerCommandHandler, TestExplorerCommandHandler);
 
diff --git a/src/client/unittests/types.ts b/src/client/unittests/types.ts
@@ -7,7 +7,7 @@
 import {
     DiagnosticSeverity, Disposable, DocumentSymbolProvider,
     Event, Location, ProviderResult, TextDocument,
-    TreeDataProvider, TreeItem, Uri
+    TreeDataProvider, TreeItem, Uri, WorkspaceFolder
 } from 'vscode';
 import { Product, Resource } from '../common/types';
 import { CommandSource } from './common/constants';
@@ -16,7 +16,6 @@ import {
     TestFile, TestFolder, TestFunction, TestRunOptions, Tests,
     TestStatus, TestsToRun, TestSuite, UnitTestProduct
 } from './common/types';
-import { TestTreeItem } from './explorer/testTreeViewItem';
 
 export const IUnitTestConfigurationService = Symbol('IUnitTestConfigurationService');
 export interface IUnitTestConfigurationService {
@@ -157,13 +156,24 @@ export interface ILocationStackFrameDetails {
 
 export type WorkspaceTestStatus = { workspace: Uri; status: TestStatus };
 
-export type TestDataItem = TestFolder | TestFile | TestSuite | TestFunction;
+export type TestDataItem = TestWorkspaceFolder | TestFolder | TestFile | TestSuite | TestFunction;
+
+export class TestWorkspaceFolder {
+    public status?: TestStatus;
+    constructor(public readonly workspaceFolder: WorkspaceFolder) { }
+    public get resource(): Uri {
+        return this.workspaceFolder.uri;
+    }
+    public get name(): string {
+        return this.workspaceFolder.name;
+    }
+}
 
 export const ITestTreeViewProvider = Symbol('ITestTreeViewProvider');
-export interface ITestTreeViewProvider<T> extends TreeDataProvider<T> {
-    onDidChangeTreeData: Event<T | undefined>;
-    getTreeItem(element: T): Promise<TreeItem>;
-    getChildren(element?: T): ProviderResult<T[]>;
+export interface ITestTreeViewProvider extends TreeDataProvider<TestDataItem> {
+    onDidChangeTreeData: Event<TestDataItem | undefined>;
+    getTreeItem(element: TestDataItem): Promise<TreeItem>;
+    getChildren(element?: TestDataItem): ProviderResult<TestDataItem[]>;
     refresh(resource: Uri): void;
 }
 
diff --git a/src/test/unittests/common/testUtils.unit.test.ts b/src/test/unittests/common/testUtils.unit.test.ts
diff --git a/src/test/unittests/explorer/explorerTestData.ts b/src/test/unittests/explorer/explorerTestData.ts
diff --git a/src/test/unittests/explorer/testTreeViewItem.unit.test.ts b/src/test/unittests/explorer/testTreeViewItem.unit.test.ts
diff --git a/src/test/unittests/explorer/testTreeViewProvider.unit.test.ts b/src/test/unittests/explorer/testTreeViewProvider.unit.test.ts

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+Support mult-root workspaces in test explorer.`