code reviews

Author: Kartik Raj

src/client/unittests/common/services/unitTestDiagnosticService.ts

@@ -12,8 +12,8 @@ import { TestStatus } from '../types';
 @injectable()
 export class UnitTestDiagnosticService implements IUnitTestDiagnosticService {
     private MessageTypes = new Map<TestStatus, DiagnosticMessageType>();
-    private MessageSeverities = new Map<PythonUnitTestMessageSeverity, DiagnosticSeverity | null>();
-    private MessagePrefixes = new Map<DiagnosticMessageType | undefined, string>();
+    private MessageSeverities = new Map<PythonUnitTestMessageSeverity, DiagnosticSeverity | undefined>();
+    private MessagePrefixes = new Map<DiagnosticMessageType, string>();
 
     constructor() {
         this.MessageTypes.set(TestStatus.Error, DiagnosticMessageType.Error);
@@ -23,17 +23,17 @@ export class UnitTestDiagnosticService implements IUnitTestDiagnosticService {
         this.MessageSeverities.set(PythonUnitTestMessageSeverity.Error, DiagnosticSeverity.Error);
         this.MessageSeverities.set(PythonUnitTestMessageSeverity.Failure, DiagnosticSeverity.Error);
         this.MessageSeverities.set(PythonUnitTestMessageSeverity.Skip, DiagnosticSeverity.Information);
-        this.MessageSeverities.set(PythonUnitTestMessageSeverity.Pass, null);
+        this.MessageSeverities.set(PythonUnitTestMessageSeverity.Pass, undefined);
         this.MessagePrefixes.set(DiagnosticMessageType.Error, localize.UnitTests.testErrorDiagnosticMessage());
         this.MessagePrefixes.set(DiagnosticMessageType.Fail, localize.UnitTests.testFailDiagnosticMessage());
         this.MessagePrefixes.set(DiagnosticMessageType.Skipped, localize.UnitTests.testSkippedDiagnosticMessage());
         this.MessagePrefixes.set(DiagnosticMessageType.Pass, '');
     }
-    public getMessagePrefix(status: TestStatus): string | undefined{
-        const hello = this.MessageTypes.get(status);
-        return this.MessagePrefixes.get(hello);
+    public getMessagePrefix(status: TestStatus): string | undefined {
+        const msgType = this.MessageTypes.get(status);
+        return msgType ? this.MessagePrefixes.get(msgType!) : undefined;
     }
-    public getSeverity(unitTestSeverity: PythonUnitTestMessageSeverity): DiagnosticSeverity | null | undefined {
+    public getSeverity(unitTestSeverity: PythonUnitTestMessageSeverity): DiagnosticSeverity | undefined {
         return this.MessageSeverities.get(unitTestSeverity);
     }
 }

src/client/unittests/types.ts

@@ -113,7 +113,7 @@ export interface IUnitTestHelper {
 export const IUnitTestDiagnosticService = Symbol('IUnitTestDiagnosticService');
 export interface IUnitTestDiagnosticService {
     getMessagePrefix(status: TestStatus): string | undefined;
-    getSeverity(unitTestSeverity: PythonUnitTestMessageSeverity): DiagnosticSeverity | null | undefined;
+    getSeverity(unitTestSeverity: PythonUnitTestMessageSeverity): DiagnosticSeverity | undefined;
 }
 
 export interface IPythonUnitTestMessage {