Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

After DeprecatePythonPath experiment is finished, remove the experiment and more #11110

Closed
6 tasks
Tracked by #11015
karrtikr opened this issue Apr 12, 2020 · 1 comment
Closed
6 tasks
Tracked by #11015

After DeprecatePythonPath experiment is finished, remove the experiment and more #11110

karrtikr opened this issue Apr 12, 2020 · 1 comment
Labels
area-environments Features relating to handling interpreter environments feature-request Request for new features or functionality needs PR Ready to be worked on

Comments

@karrtikr
Copy link

  • Remove pythonPath string from the extension
  • Remove other references to pythonPath. For eg. PYTHON_PATH etc.
  • Remove the experiment
  • Undocument pythonPath settings on workspace level
  • Fix all failing tests with experiment on
  • Note this.config.getSettings(...).pythonPath API won't work in the constructor when in Experiment. --- ANNOUNCE IT
@karrtikr karrtikr added feature-request Request for new features or functionality needs PR triage-needed Needs assignment to the proper sub-team area-environments Features relating to handling interpreter environments labels Apr 12, 2020
@ghost ghost removed the triage-needed Needs assignment to the proper sub-team label Apr 12, 2020
@karrtikr karrtikr mentioned this issue Apr 12, 2020
Closed
21 tasks
@karrtikr karrtikr self-assigned this Apr 17, 2020
@karrtikr karrtikr removed their assignment May 11, 2020
@kimadeline kimadeline mentioned this issue Mar 2, 2021
Closed
14 tasks
@github-actions github-actions bot removed the needs PR label Aug 9, 2022
@karrtikr karrtikr added the needs PR Ready to be worked on label Aug 9, 2022
@karrtikr
Copy link
Author

pythonPath is still being used in the extension, other issues are now fixed.

@karrtikr karrtikr closed this as not planned Won't fix, can't repro, duplicate, stale Dec 14, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-environments Features relating to handling interpreter environments feature-request Request for new features or functionality needs PR Ready to be worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@karrtikr