Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Experiments.json can no longer be read from 'master' branch #13839

Closed
rchiodo opened this issue Sep 8, 2020 · 1 comment
Closed

Experiments.json can no longer be read from 'master' branch #13839

rchiodo opened this issue Sep 8, 2020 · 1 comment
Assignees
@karthiknadig
Labels
bug Issue identified by VS Code Team member as probable bug regression Bug didn't exist in a previous release

Comments

@rchiodo
Copy link

rchiodo commented Sep 8, 2020 •
edited
Loading

Some customers are noticing that they are no longer part of certain experiments. This is because the released version of the extension looks for experiments.json in the 'master' branch.

You can see it in this log for example:
https://github.com/microsoft/vscode-python/issues/13837
@rchiodo rchiodo added bug Issue identified by VS Code Team member as probable bug triage-needed Needs assignment to the proper sub-team labels Sep 8, 2020
@rchiodo
Copy link
Author

rchiodo commented Sep 8, 2020

This would affect all of our old experiments (which we're still relying on for some stuff).

@brettcannon brettcannon added the P0 label Sep 8, 2020
@karthiknadig karthiknadig self-assigned this Sep 8, 2020
@ghost ghost removed the triage-needed Needs assignment to the proper sub-team label Sep 8, 2020
@karthiknadig karthiknadig mentioned this issue Sep 9, 2020
Merged
@brettcannon brettcannon added the regression Bug didn't exist in a previous release label Sep 9, 2020
@ghost ghost removed the needs PR label Sep 10, 2020
@marcdumais-work marcdumais-work mentioned this issue Nov 5, 2020
Open
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@karthiknadig karthiknadig

Labels
bug Issue identified by VS Code Team member as probable bug regression Bug didn't exist in a previous release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@brettcannon @karthiknadig @rchiodo