Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pop-up to install refactoring library appears when extensions invoke the rename provider, continues to appear after clicking "No" #15831

Closed
rjzupkoii opened this issue Apr 1, 2021 · 3 comments
Assignees
Labels
area-intellisense LSP-related functionality: auto-complete, docstrings, navigation, refactoring, etc. bug Issue identified by VS Code Team member as probable bug verified Verification succeeded

Comments

@rjzupkoii
Copy link

rjzupkoii commented Apr 1, 2021

Environment data

  • VS Code version: Version 1.55.0
  • Extension version: v2021.3.680753044
  • OS and version: Windows 10 Pro (20H2)
  • Python version (& distribution if applicable, e.g. Anaconda): 3.8.3 32-bit
  • Type of virtual environment used: N/A
  • Relevant/affected Python packages and their versions: XXX
  • Relevant/affected Python-related VS Code extensions and their versions: XXX
  • Value of the python.languageServer setting: Jedi

Other Extensions

  • Code Spell Checker (v1.10.2) with cSpell.fixSpellingWithRenameProvider set to true

Expected behaviour

When extensions use the rename provider to edit the source file (ex., to correct spelling errors in comments or strings), I should not be prompted to install the refactoring library "rope". If I decline to install the refactoring library, I should not be prompted to do so for the remainder of my session (resuming no means of disabling the prompt).

Actual behaviour

Prompt appears in lower right corner of screen asking if I wish to install the refactoring library "rope", clicking "No" dismisses the dialog but it reappears when correcting another spelling error. Rope was uninstalled due to a similar contextual error occurring see python-rope/rope#338

Steps to reproduce:

  1. Create a new Python file
  2. Enter a comment or string with a spelling error:
# Spelling error: vlaue
test = 'Spelling error: vlaue'
  1. Use Code Spell Checker to correct the spelling errors (i.e., select "Value" from the list)
  2. Prompt to install "rope" appears in lower right corner of screen (see below)

Install prompt for the rope refactoring library

Work arounds

The Code Spell Checker has the setting cSpell.fixSpellingWithRenameProvider, which when set to false prevents this error from occuring.

Logs

No logs are generated.

@rjzupkoii rjzupkoii added triage-needed Needs assignment to the proper sub-team bug Issue identified by VS Code Team member as probable bug labels Apr 1, 2021
@rjzupkoii
Copy link
Author

With a bit of digging I was able to figure out that the Code Spell Checker is triggering the events that are driving this error and a workaround is in place by setting cSpell.fixSpellingWithRenameProvider to false. Issue has been revised to reflect that the dialog keeps popping up as the primary concern (ideally I should be able to turn that off for the session).

@rjzupkoii rjzupkoii changed the title Pop-up to install refactoring library appears after correcting spelling errors, continues to appear after clicking "No" Pop-up to install refactoring library appears when extensions invoke the rename provider, continues to appear after clicking "No" Apr 1, 2021
@karthiknadig karthiknadig added area-intellisense LSP-related functionality: auto-complete, docstrings, navigation, refactoring, etc. triage and removed triage-needed Needs assignment to the proper sub-team labels Apr 5, 2021
@paulacamargo25
Copy link

We just wanted to quickly acknowledge your reported issue and let you know we will try to triage it as soon as we can.

@kimadeline
Copy link

rope is being removed in the 2021.10 release (#17225), closing this issue as stale.

@kimadeline kimadeline added the verified Verification succeeded label Sep 21, 2021
@kimadeline kimadeline added this to the September 2021 milestone Sep 21, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-intellisense LSP-related functionality: auto-complete, docstrings, navigation, refactoring, etc. bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants