Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prompt to install Pip when pip not available #15937

Closed
DonJayamanne opened this issue Apr 13, 2021 · 6 comments
Closed

Prompt to install Pip when pip not available #15937

DonJayamanne opened this issue Apr 13, 2021 · 6 comments
Assignees
Labels
area-environments Features relating to handling interpreter environments feature-request Request for new features or functionality

Comments

@DonJayamanne
Copy link

DonJayamanne commented Apr 13, 2021

If Pip isn't available then users cannot install python packages (for non-conda, non-pipenv, poetry projects).

Suggestion - why not ask the user to install pip. This way users can install the packages.

Today we (Jupyter extension) know plenty of users do not install ipykernel & we believe this is because pip isnt' available on their systems. Added issue to gather better telemetry for this #15933

Either way having a prompt to install pip would be a good thing (i think)
If you're ok with this, we'd like to get this in as this would help with our OKR of improve kernel startup success rates (i.e user will be able to install ipykernel once they isntall pip, today they just get an error message from Python extension about this, suggestion is to unblock the user rather than letting them figure out the solution).

@brettcannon @luabud /cc

@joyceerhl
Copy link

This is especially likely to happen on Codespaces VMs running older flavors of Linux, e.g. I just dealt with missing pip on a Codespace earlier today.

@luabud luabud added area-environments Features relating to handling interpreter environments needs PR feature-request Request for new features or functionality and removed triage-needed Needs assignment to the proper sub-team labels Apr 13, 2021
@luabud
Copy link
Member

luabud commented Apr 13, 2021

Can we show this just before we detect we need to install something, instead of prompting on load? The VS Code team has asked us to avoid showing notifications on load, it's better to show it just in time/when needed.

At the same time, I would like to avoid scenarios like the following:

  1. User clicks to format document
  2. We show "formatter not installed" prompt
  3. User clicks "install"
  4. We show "pip is not installed" prompt

Ideally we'd show the "pip is not installed" notification before the "tool is not installed" notification, and in a perfect world we'd remember they wanted to install that tool and start the installation right after pip finished downloading 😅 but I imagine this would be too complicated?

@DonJayamanne
Copy link
Author

an we show this just before we detect we need to install something,

Yes thats exactly the plan.
Today we display error when installation fails, but my suggestion is to display the new prompt to ask user to install pip..

@DonJayamanne
Copy link
Author

Ideally we'd show the "pip is not installed" notification before the "tool is not installed" notification, and in a perfect world we'd remember they wanted to install that tool and start the installation right after pip finished

Agreed, and I want that perfect world

@brettcannon brettcannon added needs proposal Need to make some design decisions and removed needs PR labels Apr 13, 2021
@brettcannon
Copy link
Member

Changing this to "needs spec" since there's a lot to think through before attempting to do this.

@karrtikr
Copy link

Do we still need this with most installation now moved to Jupyter? I think we've moved out most use cases for this, hence closing. But if I'm wrong please feel free to reopen.

@karrtikr karrtikr closed this as not planned Won't fix, can't repro, duplicate, stale Sep 13, 2023
@github-actions github-actions bot removed the needs proposal Need to make some design decisions label Sep 13, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-environments Features relating to handling interpreter environments feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

5 participants