-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PTVS engine download logic seems off #1643
Comments
Yes, it is usable without .NET. There are two types of engine binaries
The plan is that (1) is packaged with the extension since size is relatively small ~4MB. The logic is as follows.
Here you see the error since you probably have .NET runtime BUT pre-packaged MSIL bits are missing (they are not currently included in the public insider builds). You can build them yourself - see contributing guildelines. Or contact me [mikhaila] AT microsoft DOT com
|
I got it compiled and working using this: git clone --depth 1 https://github.com/microsoft/ptvs
cd ptvs/Python/Product/VsCode/AnalysisVsc
dotnet build
../../../../BuildOutput/VsCode/raw/
mkdir "/Users/$USER/.vscode/extensions/ms-python.python-2018.4.0/analysis"
cp ../../../../BuildOutput/VsCode/raw/*.{dll,pdb,json} "/Users/$USER/.vscode/extensions/ms-python.python-2018.4.0/analysis" but then after a few seconds it seemed doing something, I got: (Click to expand)
Edit: Apparently, compiling as |
Yes, we switched to Release builds. I am going to close this one, feel free to open new issues as needed. |
Disclaimer: I do realize that this is considered an unsupported experimental feature.
The current nightly build does not seem to include #1613 but at the first glance it does not seem to change the logic.
It seems that if my machine already has a .NET SDK the extension will never download the analysis engine:
https://github.com/Microsoft/vscode-python/blob/f18a5ee52999d0cd0d3dec61f5534c6246e85d87/src/client/activation/analysis.ts#L120-L124
The error is:
Which is true as the engine was never downloaded.
I'm not sure how to fix it though, is the nuget package meant to be usable if the .NET runtime is not installed? If not, shouldn't the condition be reversed?
By the way, it was hard to find the actual exception as it seems each linter run clears the contents of the "Python" panel in the "Output" tab and the exception is not logged anywhere else.
The text was updated successfully, but these errors were encountered: