Enable linters also on Jupyter notebooks

[antoniolanza1996]

When we work with *.py files, we can select a Linter (e.g. flake8) and it will support us to be PEP8 complaint. Hence, I'm asking for the same functionality, but in the *.ipynb files.

Is there any chance this feature will be included in future releases?

[claudiaregio]

Thanks @antoniolanza1996, we will discuss where this lands on our roadmap during our next triage meeting

[rchiodo]

This is really a python bug. The python extension would handle this.

[karthiknadig]

Thanks for the feature request! We are going to give the community 60 days from when this issue was created to provide 5 👍 upvotes on the opening comment to gauge general interest in this idea. If there's enough upvotes then we will consider this feature request in our future planning. If there's unfortunately not enough upvotes then we will close this issue.

[brettcannon]

While this didn't meet our upvote threshold, LSP is looking at adding notebook support and thus we can look at supporting it when we redo linting support as separate extensions using LSP.

[MarthinusBosman]

Just want to mention, regarding upvote threshold, that I've personally been interested in this feature for more than a year, but it's REALLY difficult to track this issue, as it's floated around to so many places.

Really hope the LSP thing brings support for this, I'm sure a lot of people would like this, but just can't find it.

[karthiknadig]

@MarthinusBosman The LSP specification 3.17 which adds the Notebook support was published recently. The Python LSP implementation that we depend on pygls (an external project) is working on updating to the LSP 3.17 spec. Once that is done, we can start enabling this in the tools specific extensions, like pylint here microsoft/vscode-pylint#20 and flake8 here microsoft/vscode-flake8#31

[MarthinusBosman]

@karthiknadig That's great news!

[c0m]

There's a lot more interest in this today, going by the latest comments and upvotes on microsoft/vscode-jupyter#1231 in the last year alone.

For those interested who can't wait, there's a workaround that exists today to get pygls working with notebooks detailed in openlawlibrary/pygls#311 and an issue to track 3.17 progress (nearly there!) in openlawlibrary/pygls#346.

There's even more relevant discussion that can be found at openlawlibrary/pygls#356 and openlawlibrary/pygls#357.

[Sigmoidas]

It seems like Microsoft gave up on VS Code Jupyter Notebook Linting (as the microsoft/vscode-jupyter/issues/1231 has been closed?

[karthiknadig]

The linting support will be handled by individual linter extensions, and not in the Jupyter Extension.

FYI, openlawlibrary/pygls#311 just merged last week. Once that is released we can begin the work to add this support in the linter extensions.

[dhruvmanila]

For reference, I've a working implementation for Ruff at astral-sh/ruff-lsp#264

[karthiknadig]

@dhruvmanila I have left some minor comments. My plan is to do something similar in the linter extensions.

[karthiknadig]

This is now tracked in linter specific extension repos:
pylint: microsoft/vscode-pylint#20
flake8: microsoft/vscode-flake8#31