Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inherit environment in a dev container #18510

Closed
kieferrm opened this issue Feb 11, 2022 · 2 comments · Fixed by #18922
Closed

Inherit environment in a dev container #18510

kieferrm opened this issue Feb 11, 2022 · 2 comments · Fixed by #18922
Assignees
Labels
area-terminal bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority needs spike Label for issues that need investigation before they can be worked on.

Comments

@kieferrm
Copy link
Member

  1. open https://github.com/Chuxel/notebooks-test in a dev container
  2. open the notebook file
    -> you get the following notification

image

terminal.integrated.inheritEnv is a user scoped setting, so the dev container cannot override it but we do control the path variable in a dev container which should prevent any issues. Any reasons simply don't show the notification in dev containers?

@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Feb 11, 2022
@brettcannon
Copy link
Member

I wonder if our transition to conda run helps negate our historical issue with the environment inheritance setting overall?

@karthiknadig karthiknadig added area-terminal bug Issue identified by VS Code Team member as probable bug triage and removed triage-needed Needs assignment to the proper sub-team labels Feb 14, 2022
@karrtikr karrtikr added investigating We are looking into the cause of the issue and removed triage labels Feb 14, 2022
@karrtikr
Copy link

karrtikr commented Feb 22, 2022

conda run in combination of #11039 should solve this so we won't need the prompt. Check #5764 to verify whether conda run helps.

so the dev container cannot override it but we do control the path variable in a dev container which should prevent any issues

If it doesn't help, look into how we can influence PATH variable in other ways as suggested here.

@karrtikr karrtikr added needs spike Label for issues that need investigation before they can be worked on. and removed investigating We are looking into the cause of the issue labels Feb 22, 2022
@karrtikr karrtikr removed their assignment Feb 22, 2022
@karrtikr karrtikr added the important Issue identified as high-priority label Feb 22, 2022
@karrtikr karrtikr self-assigned this Apr 13, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-terminal bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority needs spike Label for issues that need investigation before they can be worked on.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants