Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to adapter level UUID handling for testing #21029

Closed
eleanorjboyd opened this issue Apr 10, 2023 · 1 comment
Closed

Switch to adapter level UUID handling for testing #21029

eleanorjboyd opened this issue Apr 10, 2023 · 1 comment
Assignees
Labels
area-testing debt Covers everything internal: CI, testing, refactoring of the codebase, etc.
Milestone

Comments

@eleanorjboyd
Copy link
Member

Previously the rewrite code used the server.ts file to manage all UUIDs for the requests sent to the server but this needs to actually be on the adapter level. There is one server but multiple adapters per vscode window and therefore this structure makes the most sense.

@eleanorjboyd eleanorjboyd added debt Covers everything internal: CI, testing, refactoring of the codebase, etc. area-testing labels Apr 10, 2023
@eleanorjboyd eleanorjboyd added this to the April 2023 milestone Apr 10, 2023
@eleanorjboyd eleanorjboyd self-assigned this Apr 10, 2023
@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Apr 10, 2023
@eleanorjboyd eleanorjboyd removed the triage-needed Needs assignment to the proper sub-team label Apr 10, 2023
@eleanorjboyd
Copy link
Member Author

closed by: e288f8b, 3c84470, and d637d92.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-testing debt Covers everything internal: CI, testing, refactoring of the codebase, etc.
Projects
None yet
Development

No branches or pull requests

1 participant