Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebook support for linting and formatting #21142

Closed
1 of 6 tasks
karthiknadig opened this issue Apr 28, 2023 · 6 comments
Closed
1 of 6 tasks

Notebook support for linting and formatting #21142

karthiknadig opened this issue Apr 28, 2023 · 6 comments
Assignees
Labels
area-formatting area-linting feature-request Request for new features or functionality meta Issue that is tracking an overall project needs PR Ready to be worked on

Comments

@karthiknadig
Copy link
Member

karthiknadig commented Apr 28, 2023

  • Implement Notebook support in pygls
  • Implement Linting for notebooks in pylint.
  • Implement Linting for notebooks in flake8.
  • Implement Linting for notebooks in mypy.
  • Implement Formatting for notebooks in black
  • Implement Formatting for notebooks in autopep8
@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Apr 28, 2023
@karthiknadig karthiknadig added feature-request Request for new features or functionality area-linting area-formatting needs PR Ready to be worked on and removed triage-needed Needs assignment to the proper sub-team labels Apr 28, 2023
@karthiknadig karthiknadig self-assigned this Apr 28, 2023
@karthiknadig karthiknadig added this to the May 2023 milestone Apr 28, 2023
@karthiknadig karthiknadig added the meta Issue that is tracking an overall project label Apr 28, 2023
@rebornix
Copy link
Member

rebornix commented May 9, 2023

@karthiknadig currently we have "Format Notebook" command in the core and also notebook format on save. If users have black extensions installed, it works as expected. May I ask if this would change how we run formatters from the core?

@karthiknadig
Copy link
Member Author

From what I can tell, it should not. The LSP server registers itself as a server that can handle notebooks. When I have a prototype ready, we can look at how LSP client handles notebook mode registration.

@karthiknadig karthiknadig modified the milestones: May 2023, June 2023 May 23, 2023
@karthiknadig karthiknadig modified the milestones: June 2023, July 2023 Jun 26, 2023
@karthiknadig karthiknadig modified the milestones: July 2023, August 2023 Jul 24, 2023
@karthiknadig karthiknadig removed this from the August 2023 milestone Aug 28, 2023
@eleanorjboyd
Copy link
Member

eleanorjboyd commented Dec 16, 2024

@karthiknadig Should this be closed now that the same feature requests are in the tools extensions?

@karthiknadig
Copy link
Member Author

That is correct the requests are in the tools extensions

@rootsmusic
Copy link

rootsmusic commented Dec 16, 2024

That is correct the requests are in the tools extensions

@karthiknadig I don't see this request in autopep8

(Found for flake8.)

@karthiknadig
Copy link
Member Author

@rootsmusic There is no support for notebooks in autopep8. So we can't provide it.

For flake8 or pylint, try the Ruff extension, it has support for linting, and formatting via the ruff library which supports flake8, pylint rules, and uses black rules for formatting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-formatting area-linting feature-request Request for new features or functionality meta Issue that is tracking an overall project needs PR Ready to be worked on
Projects
None yet
Development

No branches or pull requests

4 participants