Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change interpreters list into an Observable list #3023

Closed
DonJayamanne opened this issue Oct 25, 2018 · 2 comments
Closed

Change interpreters list into an Observable list #3023

DonJayamanne opened this issue Oct 25, 2018 · 2 comments
Labels
area-environments Features relating to handling interpreter environments area-internal Label for non-user facing issues debt Covers everything internal: CI, testing, refactoring of the codebase, etc.

Comments

@DonJayamanne
Copy link

DonJayamanne commented Oct 25, 2018

See #2853

Today we need the following from the list of interpreters:

  • Do we have any items in the list? (we wait for everything to complete)
  • Filtering the list to check if a certain type exists
  • Monitor new items in the list
  • Standard list operations

Each of the above operations have corresponding operations in an Observable list (any, filter, subsribe, etc - all in non-blocking way).
We need to start using Observable lists, i.e. RxJs (as we're slowly but steadily adding code that comes out of the box with RxJs).

Benefits:

  • Simpler api
  • Less code
  • Faster (non-blocking - as we do not need to wait for everything to complete)
@DonJayamanne DonJayamanne added P2 debt Covers everything internal: CI, testing, refactoring of the codebase, etc. labels Oct 25, 2018
@DonJayamanne DonJayamanne removed the P2 label Jan 30, 2019
@gramster gramster added area-environments Features relating to handling interpreter environments and removed feature-interpreter labels Oct 10, 2019
@karthiknadig karthiknadig added area-internal Label for non-user facing issues and removed cause-perf labels Mar 11, 2020
@luabud
Copy link
Member

luabud commented Feb 16, 2021

We're changing the way we handle the interpreters list with #12020. So closing as stale.

@luabud luabud closed this as completed Feb 16, 2021
@ghost ghost removed the needs PR label Feb 16, 2021
@DonJayamanne
Copy link
Author

@karthiknadig this is my original proposal

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-environments Features relating to handling interpreter environments area-internal Label for non-user facing issues debt Covers everything internal: CI, testing, refactoring of the codebase, etc.
Projects
None yet
Development

No branches or pull requests

4 participants