[Insiders] Language server fails to install

[qubitron]

Environment data

• VS Code version: 1.28.2 (user setup)
• Extension version (available under the Extensions sidebar): 2018.10.0-alpha
• OS and version: Windows 10
• Python version (& distribution if applicable, e.g. Anaconda): Pyhon 3.7 64 bit
• Type of virtual environment used (N/A | venv | virtualenv | conda | ...): venv
• Relevant/affected Python packages and their versions: N/A

Actual behavior

Language server downloads and extracts but never loads and fails with an error in the console, language server fails to start after reloading VS Code

Expected behavior

Language server downloads and loads

Steps to reproduce:

1. Install latest extension with jediEnabled: false in user settings
2. open a python file

Logs

Output for Python in the Output panel (View→Output, change the drop-down the upper-right of the Output panel to Python)

Starting Microsoft Python language server.
Downloading https://pvsc.azureedge.net/python-language-server-beta/Python-Language-Server-osx-x64.0.1.50.nupkg... complete.
Unpacking archive... extraction failed.
Error: ENOENT: no such file or directory, chmod 'c:\Users\dantaylo\.vscode\extensions\ms-python.python-2018.10.0-alpha\languageServer.0.1.50\Microsoft.Python.LanguageServer.exe'

Output from Console under the Developer Tools panel (toggle Developer Tools on under Help)

[Extension Host] Python Extension: Get latest language server nuget package version, , Return Value: {"package":"Python-Language-Server-osx-x64.0.1.50.nupkg","uri":"https://pvsc.azureedge.net/python-language-server-beta/Python-Language-Server-osx-x64.0.1.50.nupkg","version":{"loose":true,"raw":"0.1.50","major":0,"minor":1,"patch":50,"prerelease":[],"build":[],"version":"0.1.50"}}
console.ts:136 [Extension Host] Python Extension: Get latest version of Language Server, , Return Value: {"package":"Python-Language-Server-osx-x64.0.1.50.nupkg","uri":"https://pvsc.azureedge.net/python-language-server-beta/Python-Language-Server-osx-x64.0.1.50.nupkg","version":{"loose":true,"raw":"0.1.50","major":0,"minor":1,"patch":50,"prerelease":[],"build":[],"version":"0.1.50"}}
extensionService.ts:1009 Activating extension 'ms-python.python' failed: Error: ENOENT: no such file or directory, chmod 'c:\Users\dantaylo\.vscode\extensions\ms-python.python-2018.10.0-alpha\languageServer.0.1.50\Microsoft.Python.LanguageServer.exe'.
E._logMessageInConsole @ extensionService.ts:1009
console.ts:136 [Extension Host] Activating extension 'ms-python.python' failed: Error: ENOENT: no such file or directory, chmod 'c:\Users\dantaylo\.vscode\extensions\ms-python.python-2018.10.0-alpha\languageServer.0.1.50\Microsoft.Python.LanguageServer.exe'.
t.log @ console.ts:136
console.ts:136 [Extension Host] Activating extension `ms-python.python` failed:  Error: ENOENT: no such file or directory, chmod 'c:\Users\dantaylo\.vscode\extensions\ms-python.python-2018.10.0-alpha\languageServer.0.1.50\Microsoft.Python.LanguageServer.exe'
t.log @ console.ts:136
console.ts:136 [Extension Host] Here is the error stack:  Error: Error: ENOENT: no such file or directory, chmod 'c:\Users\dantaylo\.vscode\extensions\ms-python.python-2018.10.0-alpha\languageServer.0.1.50\Microsoft.Python.LanguageServer.exe'
	at LanguageServerDownloader.<anonymous> (C:\Users\dantaylo\.vscode\extensions\ms-python.python-2018.10.0-alpha\out\client\activation\downloader.js:69:23)
	at Generator.throw (<anonymous>)
	at rejected (C:\Users\dantaylo\.vscode\extensions\ms-python.python-2018.10.0-alpha\out\client\activation\downloader.js:7:65)
	at <anonymous>

[brettcannon]

I can reproduce. Looks like there is no Microsoft.Python.LanguageServer.exe in the extracted directory, but there is Microsoft.Python.LanguageServer. Did the language server team rename the file?

[brettcannon]

Nope, if you look closely you will notice that the OS X file is getting downloaded for some reason.

[brettcannon]

The nupkg is in the Blob storage, so something else is going on. If you look at Developer Tools you will notice that no Windows file is returned as an option, only macOS:

Extension: Listing Nuget Packages, Arg 1: "https://pvsc.azureedge.net", Arg 2: "python-language-server-beta", Arg 3: "Python-Language-Server-win-x64", Return Value: [{"package":"Python-Language-Server-osx-x64.0.1.48.nupkg","uri":"https://pvsc.azureedge.net/python-language-server-beta/Python-Language-Server-osx-x64.0.1.48.nupkg","version":{"loose":true,"raw":"0.1.48","major":0,"minor":1,"patch":48,"prerelease":[],"build":[],"version":"0.1.48"}},{"package":"Python-Language-Server-osx-x64.0.1.50.nupkg","uri":"https://pvsc.azureedge.net/python-language-server-beta/Python-Language-Server-osx-x64.0.1.50.nupkg","version":{"loose":true,"raw":"0.1.50","major":0,"minor":1,"patch":50,"prerelease":[],"build":[],"version":"0.1.50"}}]

[DonJayamanne]

CDN is caching the query results.
Closing in favor of #3000