Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrated terminal with zsh shell should use Python virtualenv #4786

Closed
dinhkim opened this issue Mar 17, 2019 · 2 comments
Closed

Integrated terminal with zsh shell should use Python virtualenv #4786

dinhkim opened this issue Mar 17, 2019 · 2 comments
Assignees

Comments

@dinhkim
Copy link

dinhkim commented Mar 17, 2019

Environment data

  • VS Code version: 1.32.3
  • Extension version: 2019.2.5558
  • OS and version: Windows 10 (Build 1809)
  • Python version: 3.7.2
  • Type of virtual environment used: venv
  • Shell of Integrated Terminal: zsh (C:\msys64\usr\bin\zsh.exe)

Expected behaviour

VS-Code integrated terminal should use the path to virtualenv python not the system default

Actual behaviour

When a virtualenv is selected, the integrated terminal (zsh) does not use the virtual environment.
However, if I use bash shell for the integrated terminal, everything is working fine.

Steps to reproduce:

  1. python.pythonPath is set to virtual environment path
  2. Open the integrated terminal
  3. python --version in integrated terminal shows system version
@ghost ghost added the triage-needed Needs assignment to the proper sub-team label Mar 17, 2019
@dinhkim
Copy link
Author

dinhkim commented Mar 17, 2019

I think the "src/client/common/terminal/helper.ts" file need to be updated to detect the zsh shell of msys2 on Windows.

@ghost ghost removed the triage-needed Needs assignment to the proper sub-team label Mar 18, 2019
@DonJayamanne
Copy link

Unfortunately we do not support msys2, closing in favor of #67

@ghost ghost removed the triage label Mar 18, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Apr 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants