Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Parso and point to release Jedi #773

Closed
MikhailArkhipov opened this issue Feb 13, 2018 · 1 comment
Closed

Update Parso and point to release Jedi #773

MikhailArkhipov opened this issue Feb 13, 2018 · 1 comment
Assignees
Labels
area-intellisense LSP-related functionality: auto-complete, docstrings, navigation, refactoring, etc. debt Covers everything internal: CI, testing, refactoring of the codebase, etc.
Milestone

Comments

@MikhailArkhipov
Copy link

Continuation of #674

I think you left old files from a previous version of Jedi.
Jedi know depends on Parso, which is missing.
You default to the "preview" version
vscode-python/src/client/providers/jediProxy.ts

Lines 291 to 299 in 6015468

         if (typeof this.pythonSettings.jediPath !== 'string' || this.pythonSettings.jediPath.length === 0) { 
             if (Array.isArray(this.pythonSettings.devOptions) && 
                 this.pythonSettings.devOptions.some(item => item.toUpperCase().trim() === 'USERELEASEAUTOCOMP')) { 
                 // Use standard version of jedi. 
                 args.push('std'); 
             } else { 
                 // Use preview version of jedi. 
                 args.push('preview'); 
             } 

rather than the new version which was placed in "stable" (I think that's a hidden config setting...).
I can open a separate issue if you want.

@MikhailArkhipov MikhailArkhipov self-assigned this Feb 13, 2018
@MikhailArkhipov MikhailArkhipov added this to the February 2018 milestone Feb 13, 2018
@MikhailArkhipov MikhailArkhipov added area-intellisense LSP-related functionality: auto-complete, docstrings, navigation, refactoring, etc. feature-refactoring debt Covers everything internal: CI, testing, refactoring of the codebase, etc. labels Feb 13, 2018
@MikhailArkhipov
Copy link
Author

5ccb9cd

@lock lock bot locked as resolved and limited conversation to collaborators Jul 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-intellisense LSP-related functionality: auto-complete, docstrings, navigation, refactoring, etc. debt Covers everything internal: CI, testing, refactoring of the codebase, etc.
Projects
None yet
Development

No branches or pull requests

1 participant