Spike - Collect all the issues related to environment issues

[karthiknadig]

No description provided.

[karrtikr]

For #8584
https://github.com/Microsoft/vscode-python/blob/b4499f03d9ace2a6b2c309ebcf5f746f6db39e99/src/client/debugger/extension/configuration/resolvers/helper.ts#L53

While resolving a debug configuration, this line in add code merges all of the process environment variables with the custom vars. So all of environment variables are sent to the Debug console.

New debug adapter also uses debug resolver to resolve configuration, so it also runs into this issue.

[karthiknadig]

For the issue #8584 , this is caused by a change in what we used to consider as internalConsole. Previously, none meant internalConsole, and console type had ["none", "integratedTerminal", "externalTerminal"] , but some time this year, that changed to ["internalConsole", "integratedTerminal", "externalTerminal"]. There is no "none" console type.
https://github.com/Microsoft/vscode-python/blob/b4499f03d9ace2a6b2c309ebcf5f746f6db39e99/src/client/debugger/extension/configuration/resolvers/helper.ts#L49

When we see console is not defined, we assume internalConsole in the debugger. But the extension assumes absence of console as integratedTerminal, and overwrites the console value. So debugger receives full set of environment variables (instead of just the diff), and uses it in integratedTerminal.

vscode-python/src/client/debugger/extension/configuration/resolvers/launch.ts

Lines 76 to 78 in b4499f0

	if (!debugConfiguration.console) {
	debugConfiguration.console = 'integratedTerminal';
	}

[karthiknadig]

couple of other issues with that code:

1. It should not be setting utf-8 encoding. At least for the new debugger.
2. gwent support will be set in the new debugger.
3. The extension should not merge PATH and PYTHONPATH. This limits usage since they will always be additive. Instead they should override, that way users can override or provide combined paths as needed.

@int19h /cc