Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging improvement #1385

Merged
merged 18 commits into from
Aug 3, 2022
Merged

Logging improvement #1385

merged 18 commits into from
Aug 3, 2022

Conversation

JiglioNero
Copy link
Contributor

@JiglioNero JiglioNero commented Sep 9, 2020

image
image
image
image
image
Closes #1272

@JiglioNero JiglioNero self-assigned this Sep 9, 2020
@SounD120 SounD120 marked this pull request as draft September 9, 2020 13:29
@SounD120
Copy link
Contributor

Closing this for branch renaming

@SounD120 SounD120 closed this Sep 18, 2020
@SounD120 SounD120 reopened this Sep 18, 2020
@SounD120 SounD120 changed the base branch from preview to master September 18, 2020 07:58
@SounD120 SounD120 marked this pull request as ready for review September 21, 2020 13:04
@JiglioNero
Copy link
Contributor Author

JiglioNero commented Mar 19, 2021

We have implemented custom TextMate tokens, with the help of which it is now possible to customize the colors of the logs in output channels:

Scope Descriprion
rnt.output.string Single and double quoted strings
rnt.output.url Links, email and ip addreses, filepaths
rnt.output.timestamp Date and time
rnt.output.numeric Constant decimal numbers
rnt.output.process Logs of processes such as npm, bundle, and other build tasks
rnt.output.error Errors, exceprions, fails and stack for them
rnt.output.warn Warning logs
rnt.output.info Info logs
rnt.output.debug Debug logs
rnt.output.verbose Verbose logs
rnt.output.constant Such values as true, false, null, undefined, NaN
rnt.output.success Logs indicating successful completion of the process, such as BUILD SUCCESSFULL and others

Now you can customize React Native Tools output logs with editor.tokenColorCustomizations parameter in settings.json this way:

 "editor.tokenColorCustomizations": {
        "textMateRules": [
            {
                "settings": {
                    "foreground": "#c57ca0",
                    "fontStyle": "bold",
                },
                "scope": "rnt.output.string"
            }
        ]
    }

@JiglioNero JiglioNero marked this pull request as draft April 1, 2022 15:33
@EzioLi01 EzioLi01 removed the request for review from SounD120 July 22, 2022 05:43
@EzioLi01 EzioLi01 removed the request for review from RedMickey July 22, 2022 05:43
@jinquan2019 jinquan2019 marked this pull request as ready for review August 2, 2022 10:02
@jinquan2019 jinquan2019 requested review from benjaminbi and EzioLi01 and removed request for jinquan2019 August 2, 2022 10:03
Copy link
Collaborator

@EzioLi01 EzioLi01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine locally.

@jinquan2019 jinquan2019 merged commit 774c1a1 into master Aug 3, 2022
@jinquan2019 jinquan2019 deleted the logging-improvement branch August 3, 2022 03:17
timonwong added a commit to timonwong/vscode-shellcheck-dev that referenced this pull request Oct 21, 2022
Signed-off-by: Timon Wong <timon86.wang@gmail.com>
timonwong added a commit to vscode-shellcheck/vscode-shellcheck that referenced this pull request Oct 21, 2022
* feat: colorize output

Signed-off-by: Timon Wong <timon86.wang@gmail.com>

* add more highlight microsoft/vscode-react-native#1385

Signed-off-by: Timon Wong <timon86.wang@gmail.com>
timonwong pushed a commit to vscode-shellcheck/vscode-shellcheck that referenced this pull request Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better logging experience
5 participants