Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create angular recipes #1

Closed
chrisdias opened this issue May 11, 2017 · 11 comments
Closed

create angular recipes #1

chrisdias opened this issue May 11, 2017 · 11 comments
Assignees
Milestone

Comments

@chrisdias
Copy link
Member

A simple Angular app: https://github.com/johnpapa/angular-tour-of-heroes

{
    "version": "0.2.0",
    "configurations": [
        {
            "type": "chrome",
            "request": "launch",
            "name": "Launch Chrome",
            "sourceMaps": true,
            "url": "http://localhost:4200",
            "webRoot": "${workspaceRoot}",
            "sourceMapPathOverrides": {
                "webpack:///./*": "${webRoot}/*"
            }
        }
    ]
}

The sourceMapPathOverrides was the important section...

@weinand
Copy link
Contributor

weinand commented May 12, 2017

/cc @roblourens

@tonysneed
Copy link

I've got a gist with launch configurations for Chrome debugging and Angular CLI. It has configs both for ng serve and ng test. Would you accept a PR?

@weinand
Copy link
Contributor

weinand commented Jun 9, 2017

@tonysneed sure, a PR would be really great!
Ideally the PR could contain a full subfolder "Angular" with a minimal sample, a readme.md and the launch config (similar to the two other subfolders).

@auchenberg
Copy link
Contributor

@tonysneed @weinand I'm in the middle of prepping a VS Code blog post about Angular (angular-cli) + our Chrome debugger. Would to be able to back reference this repo.

@tonysneed
Copy link

tonysneed commented Jun 9, 2017 via email

@tonysneed
Copy link

@weinand @auchenberg See PR #2.

@weinand weinand self-assigned this Jun 12, 2017
@weinand weinand added this to the June 2017 milestone Jun 12, 2017
@tonysneed
Copy link

@weinand Thanks for merging my PR .. Happy to be of service! 🙇

@tonysneed
Copy link

Updated the README in PR #4.
Updated launch.json in PR #5.

@tonysneed
Copy link

Removed sourceMaps, trace, userDataDir from JSON in README.md file in PR #6.

@weinand
Copy link
Contributor

weinand commented Jun 15, 2017

@tonysneed @auchenberg @roblourens thanks for your help on this recipe!

@tonysneed an official "Thank You" will appear in the June release notes.

@weinand weinand closed this as completed Jun 15, 2017
@tonysneed
Copy link

@weinand Glad I could contribute! 😎

@vscodebot vscodebot bot locked and limited conversation to collaborators Feb 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants