Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker-machine is deprecated #5403

Closed
HollisTech opened this issue Aug 2, 2021 · 3 comments · Fixed by microsoft/vscode-docs#4775
Closed

docker-machine is deprecated #5403

HollisTech opened this issue Aug 2, 2021 · 3 comments · Fixed by microsoft/vscode-docs#4775
Assignees
Labels
containers Issue in vscode-remote containers doc

Comments

@HollisTech
Copy link

The documentation for Advanced Container Configuration, has a section 'connect using docker machine' (https://code.visualstudio.com/docs/remote/containers-advanced#_connect-using-docker-machine) , but docker-machine is deprecated and no longer provided with docker desktop for windows. Instead the docker docs suggest simply using the environment variable DOCKER_HOST for remote server docker operations.

@github-actions github-actions bot added the containers Issue in vscode-remote containers label Aug 2, 2021
@bamurtaugh
Copy link
Member

Thanks for reporting @HollisTech! Would you be able to share where in the Docker docs it mentions docker-machine is deprecated? I can't seem to find it on https://docs.docker.com/machine/

@HollisTech
Copy link
Author

That section is in the section "Superseded products and tools." Also see docker/machine#4537. Docker for windows incorporates machine functionality using either the --machine parameter or the DOCKER_HOST environment variable.

@chrmarti
Copy link
Contributor

chrmarti commented Aug 9, 2021

The Docker extension comes with docker.host (same as DOCKER_HOST env variable) and docker.context (same as DOCKER_CONTEXT env variable) user settings that are also honored by the Remote-Containers extension.

Docker contexts seem to be the newer concept and could be mentioned in the documentation instead of docker-machine: https://docs.docker.com/engine/context/working-with-contexts/

Note that the above settings are only visible when the Docker extension is installed. Without the Docker extension, Remote-Containers will use the current context. The current context can be changed using docker context use <context>.

@bamurtaugh bamurtaugh self-assigned this Aug 23, 2021
@bamurtaugh bamurtaugh added the doc label Aug 25, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Oct 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
containers Issue in vscode-remote containers doc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants